Skip to content

refactor(elasticsearch): replace no-op loop-over-group in upgrade includes with a membership guard #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oddly merged 1 commit into from
Aug 11, 2026
Merged

refactor(elasticsearch): replace no-op loop-over-group in upgrade includes with a membership guard #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions roles/elasticsearch/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,12 @@
force: true
when: elasticsearch_jvm_custom_parameters is defined and (elasticsearch_jvm_custom_parameters | string | length > 0)

# Membership guard replaces the old loop-over-the-group construct, which only
# ever matched the host itself and skipped every other iteration.
- name: Update Elasticsearch if needed
ansible.builtin.include_tasks: elasticsearch-rolling-upgrade.yml
loop: "{{ groups[elasticstack_elasticsearch_group_name] }}"
when:
- "hostvars[item].inventory_hostname == inventory_hostname"
- inventory_hostname in groups[elasticstack_elasticsearch_group_name] | default([])
- _elasticsearch_needs_rolling_upgrade | bool
- elasticstack_password.stdout is defined

Expand Down Expand Up @@ -368,9 +369,8 @@

- name: Rolling restart after package upgrade
ansible.builtin.include_tasks: elasticsearch-rolling-upgrade.yml
loop: "{{ groups[elasticstack_elasticsearch_group_name] }}"
when:
- "hostvars[item].inventory_hostname == inventory_hostname"
- inventory_hostname in groups[elasticstack_elasticsearch_group_name] | default([])
- not (_elasticsearch_needs_rolling_upgrade | bool)
- _elasticsearch_package_upgraded | default(false) | bool
- elasticstack_password.stdout is defined
Expand Down
Loading