syncing fallback storage service redesign - #745
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 52.88% 48.34% -4.54%
==========================================
Files 222 210 -12
Lines 27139 23184 -3955
Branches 494 494
==========================================
- Hits 14353 11209 -3144
+ Misses 11242 10429 -813
- Partials 1544 1546 +2 |
rachel-bousfield
changed the title
Tristan-Wilson
previously approved these changes
Jul 19, 2022
Tristan-Wilson
left a comment
Tristan-Wilson
left a comment
Member
There was a problem hiding this comment.
LGTM minor comment about a comment only
| return err | ||
| } | ||
| log.Info("BatchDelivered", "log", batchDeliveredLog, "event", deliveredEvent) | ||
| storeUntil := arbmath.SaturatingUAdd(deliveredEvent.TimeBounds.MaxTimestamp, uint64(s.config.RetentionPeriod.Seconds())) // TODO: support limited retention period |
Member
There was a problem hiding this comment.
Is the TODO comment here still correct? Isn't it limited if we're only adding the retention period?
Contributor
Author
There was a problem hiding this comment.
you're right :) will remove
Tristan-Wilson
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.