Make gasprice opcode return 0 for eth_call's with a zero gas price - #799
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 48.73% 48.59% -0.14%
==========================================
Files 211 211
Lines 22939 22943 +4
Branches 494 494
==========================================
- Hits 11180 11150 -30
- Misses 10232 10261 +29
- Partials 1527 1532 +5 |
Contributor
|
I think it would be best if gasprice surfaced was actually the basefee, when eth_call is set to zero gas price. That said, this change LGTM |
PlasmaPower
approved these changes
Jul 18, 2022
PlasmaPower
left a comment
Contributor
There was a problem hiding this comment.
LGTM - we'll revert this if as upstream geth accepts Fred's PR
PlasmaPower
enabled auto-merge
July 18, 2022 22:58
Contributor
Author
|
Here's Fred's upstream issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
gaspriceopcode return the actual amount paid by the user