Skip to content

Make gasprice opcode return 0 for eth_call's with a zero gas price - #799

Merged
PlasmaPower merged 7 commits into
masterfrom
eth_call-no-poster-cost
Jul 18, 2022
Merged

Make gasprice opcode return 0 for eth_call's with a zero gas price#799
PlasmaPower merged 7 commits into
masterfrom
eth_call-no-poster-cost

Conversation

@rachel-bousfield

Copy link
Copy Markdown
Contributor

Makes the gasprice opcode return the actual amount paid by the user

@cla-bot cla-bot Bot added the cla-signed label Jul 15, 2022
@codecov

codecov Bot commented Jul 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #799 (45b6d29) into master (ff93280) will decrease coverage by 0.13%.
The diff coverage is 12.50%.

❗ Current head 45b6d29 differs from pull request most recent head 2282289. Consider uploading reports for the commit 2282289 to get more accurate results

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   48.73%   48.59%   -0.14%     
==========================================
  Files         211      211              
  Lines       22939    22943       +4     
  Branches      494      494              
==========================================
- Hits        11180    11150      -30     
- Misses      10232    10261      +29     
- Partials     1527     1532       +5     

@fredlacs

fredlacs commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

I think it would be best if gasprice surfaced was actually the basefee, when eth_call is set to zero gas price.
But that would diverge from geth (although I think geth would be better with the above behaviour)

That said, this change LGTM

@PlasmaPower PlasmaPower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we'll revert this if as upstream geth accepts Fred's PR

@PlasmaPower
PlasmaPower enabled auto-merge July 18, 2022 22:58
@rachel-bousfield

Copy link
Copy Markdown
Contributor Author

@PlasmaPower
PlasmaPower merged commit 6f8668d into master Jul 18, 2022
@rachel-bousfield
rachel-bousfield deleted the eth_call-no-poster-cost branch July 18, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants