Skip to content

fix init blocknumber offbyone - #823

Merged
tsahee merged 2 commits into
init-optionsfrom
init-offbyone
Jul 22, 2022
Merged

fix init blocknumber offbyone#823
tsahee merged 2 commits into
init-optionsfrom
init-offbyone

Conversation

@tsahee

@tsahee tsahee commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@cla-bot cla-bot Bot added the cla-signed label Jul 22, 2022
@codecov

codecov Bot commented Jul 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #823 (cfc057b) into init-options (06ada11) will increase coverage by 13.84%.
The diff coverage is 16.66%.

@@                Coverage Diff                @@
##           init-options     #823       +/-   ##
=================================================
+ Coverage         34.60%   48.45%   +13.84%     
=================================================
  Files                58      211      +153     
  Lines              2794    23059    +20265     
  Branches            494      494               
=================================================
+ Hits                967    11173    +10206     
- Misses             1827    10355     +8528     
- Partials              0     1531     +1531     

@PlasmaPower PlasmaPower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee
tsahee marked this pull request as ready for review July 22, 2022 19:15
@tsahee
tsahee merged commit c5e3261 into init-options Jul 22, 2022
@tsahee
tsahee deleted the init-offbyone branch July 22, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants