Skip to content

Support --node.dangerous.reorg-to-block with the block validator - #828

Merged
hkalodner merged 2 commits into
masterfrom
block-validator-startup-reorg
Jul 23, 2022
Merged

Support --node.dangerous.reorg-to-block with the block validator#828
hkalodner merged 2 commits into
masterfrom
block-validator-startup-reorg

Conversation

@PlasmaPower

Copy link
Copy Markdown
Contributor

This will also reorg the block validator's lastBlockValidated when reorging on startup

@PlasmaPower PlasmaPower added the node Changes the node software label Jul 22, 2022
@cla-bot cla-bot Bot added the cla-signed label Jul 22, 2022
@codecov

codecov Bot commented Jul 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #828 (20f78dc) into master (3912a73) will decrease coverage by 10.82%.
The diff coverage is 16.66%.

@@             Coverage Diff             @@
##           master     #828       +/-   ##
===========================================
- Coverage   59.27%   48.45%   -10.83%     
===========================================
  Files          70      214      +144     
  Lines        6934    23495    +16561     
  Branches      495      495               
===========================================
+ Hits         4110    11384     +7274     
- Misses       2824    10556     +7732     
- Partials        0     1555     +1555     

@hkalodner hkalodner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkalodner
hkalodner merged commit a74dbcf into master Jul 23, 2022
@hkalodner
hkalodner deleted the block-validator-startup-reorg branch July 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed node Changes the node software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants