Merge shared changes #117
Merged
Merge shared changes #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This branch enables Shared Runtime for ECF. The initial thought is that this will be branch off the Excel Custom functions repo called "shared-runtime." We can then also have a "yo-offfice-shared-runtime" for production - Added tests to verify taskpane functionality as well, which we didn't previously have for ECF. These changes should get propagated to master as well - Verfied branch works on Windows. Following up to verify works on Mac too
- Also added debug configs
…/github.com/OfficeDev/Excel-Custom-Functions into incorporating-linter-to-shared-app-template
…pp-template Adding ESLint-Plugin-Excel-Custom-Functions to Shared App Template
- Fix issue with functions.ts
- Up the debug timeout
- Seems to having the DesktopFormFactor section in the test and then trying to open the taskpane via Office.addin.showAsTaskpane() makes the test very unreliable
Add shared runtime branch
Adding a testing guideline to the CONTRIBUTING.md file. The idea is that these manual tests need be executed and pass before submitting a PR.
Merging master branch changes
Merge master branch changes into shared runtime branch
make XML and JSON versions match
…Dev/Office-Addin-TaskPane into implement-manifest-choice
Put both types of manifest in the same branch
remove obsolete line from convert script
…module User/millerds/convert without module
don't use /public path with shared runtime The shared runtime uses the browser context for execution of JavaScript custom functions, so the functions.json metadata can come from the dist folder just like the other files.
Merge shared changes
Merge master to shared-runtime
Revert "Merge master to shared-runtime"
Update messaging for M365 Developer Program
millerds
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your pull request! Please provide the following information.
Change Description:
cross-repo merge from Excel-Custom-Functions master
Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
If Yes, briefly describe what is impacted.
No
Do these changes impact VS Code debugging options (launch.json)?
If Yes, briefly describe what is impacted.
No
Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
If Yes, briefly describe what is impacted.
No
Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
If Yes, briefly describe what is impacted.
No
If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed:
Automated tests pass.
Manual test of conversion script generates expected/wanted output.