Fix PR comment sections colliding for multiple integrations - #19
Merged
Conversation
When multiple kickflip PR comment integrations run in the same workflow without an explicit --action-name, they all defaulted to the 'default' section name and overwrote each other, so only the last integration's output survived in the reused comment. Key decisions: - Added PullRequestCommentComposer.ResolveSectionName which falls back to the deployment path when no explicit action name is set, so distinct flows keep distinct sections and are combined in the shared comment. - Wired the resolver into the github pull-request handler. - Root path '/' and no path still resolve to 'default'. Files changed: - src/kickflip/Services/PullRequestCommentComposer.cs - src/kickflip/Program.cs - src/kickflip.Tests/PullRequestCommentComposerTests.cs - README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Problem
When multiple kickflip PR comment integrations run within a single GitHub workflow without an explicit
--action-name, they all defaulted to thedefaultsection name. Because kickflip reuses a single comment and upserts by section name, each integration overwrote the previous one — so only the last integration's output survived in the comment. (The GitHub job summary was correct because it only appends.)Fix
Added
PullRequestCommentComposer.ResolveSectionNamewhich falls back to the--deployment-pathwhen no explicit action name is set. Distinct flows (different deployment paths) now keep distinct sections and are combined in the shared comment instead of overwriting each other.Key decisions
--action-nameis unset (or explicitlydefault)./and no path still resolve todefault(preserving existing single-flow behaviour).github pull-requesthandler.Files changed
Verification
dotnet buildsucceedsdotnet test: 55 passed, 0 failed