Develop - #2
Merged
Merged
Conversation
anton-knyazev
requested changes
Nov 10, 2020
add max class length check add max fun length check
add simplifications function check
refactoring
anton-knyazev
requested changes
Nov 16, 2020
add args bundle for fragment checking add intent extra params checking add classes count checking add packages count checking add simplification control instruction checking
| /** Issue describing the problem and pointing to the detector implementation */ | ||
| @JvmField | ||
| val ISSUE: Issue = Issue.create( | ||
| id = "NAME_CONSTANTS_CORRECTLY", |
Contributor
There was a problem hiding this comment.
NAME_CONSTANTS_SCREAMING_SNAKE_CASE
|
|
||
| private const val MAX_CLASSES_IN_PACKAGE_COUNT = 5 | ||
|
|
||
| private var classesMap = mutableMapOf<String, ArrayList<String>>() |
Contributor
There was a problem hiding this comment.
подумать как избавить от синглотона
| override fun createUastHandler(context: JavaContext): UElementHandler? { | ||
| return object : UElementHandler() { | ||
| override fun visitExpression(node: UExpression) { | ||
| // val expression = node.expression ?: return |
change space checking logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.