Skip to content

Rename 3 spec fields of CurrencyItems.dat#129

Closed
shirohana wants to merge 1 commit intoOmegaK2:devfrom
shirohana:fix/spec-rename-fields-of-currency-items
Closed

Rename 3 spec fields of CurrencyItems.dat#129
shirohana wants to merge 1 commit intoOmegaK2:devfrom
shirohana:fix/spec-rename-fields-of-currency-items

Conversation

@shirohana
Copy link
Copy Markdown
Contributor

Renamed three fields of CurrencyItems.dat:

Directions -> Description
Description -> Usage
XBoxDirections -> XBoxDescription

I think it is more approched to the scenario, here's some sample (unimportant fields removed):

image

CurrencyItems.json

{
  "BaseItemTypesKey": 6617,
  "Stacks": 1,
  "CurrencyUseType": 3,
  "Directions": "Can be used in a personal Map Device to add modifiers to a Map.",
  "Description": "Area contains Metamorph Monsters\r\nMetamorph Bosses which drop an Itemised Sample drop two additional Itemised Samples\r\nAll Metamorph Monsters have Rewards",
  "XBoxDirections": "Can be used in a personal Map Device to add modifiers to a Map."
}

image

CurrencyItems.json

{
  "BaseItemTypesKey": 6618,
  "Stacks": 10,
  "CurrencyUseType": 3,
  "Directions": "Can be combined with other Oils at Cassia to Enchant Rings or Amulets, or to modify Blighted Maps.",
  "Description": "",
  "XBoxDirections": ""
}

@shirohana
Copy link
Copy Markdown
Contributor Author

Oh my god, I read the descriptions in other translations (Traditional Chinese), but it looks correct in English...

That's my bad, I have no double checked in English, close now... sorry for distrubed.

@shirohana shirohana closed this Aug 3, 2020
Wires77 pushed a commit to Wires77/PyPoE that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant