chore: remove zero-byte stub modules with no references (duplicated inline in rag/engine.py) - #8
Merged
Merged
Conversation
…nline in rag/engine.py) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RttwcxBgsnXH2TwQGQsrp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes 9 zero-byte stub files (0 bytes each, no content, never implemented):
retrieval/reranker.pyretrieval/context_builder.pyingestion/plugin_loader.pyingestion/repo_fetcher.pyprocessing/graph_builder.pyprocessing/metadata_builder.pyindex/keyword_index.pyutils/__init__.py— this was the only file inutils/, so the whole directory is removedscripts/ingest.pyReference search (before deleting)
Searched the full codebase —
.py,.md,.yaml/.yml,.toml,.cfg,.txt,.sh— for each module by dotted path (e.g.retrieval.reranker) and by bare name (e.g.reranker), plus a repo-wide sweep forimportlib,ImportError(try/except fallback-import patterns), and anyutilspackage usage.Result: zero functional references to any of the 9 modules anywhere outside their own file. No imports, no
__init__.pyre-exports, no dynamicimportlibloading, no try/except ImportError fallbacks.One non-functional hit found, as required to report:
README.md:132listsscripts/ingest.pyin the "Repository Structure" file tree (├── ingest.py # Standalone ingestion helper). This is a stale doc comment, not a code dependency — the file itself is empty and does nothing. It was not a blocker for deletion but is worth a follow-up doc cleanup (out of scope for this PR).The
retrieval.rerank()andretrieval/context-buildingfunctionality these stubs' names suggest already exists — implemented inline inrag/engine.py(RAGEngine.rerank()at rag/engine.py:143,RAGEngine.build_context()at rag/engine.py:214) — confirming these stub files were leftover dead placeholders, never wired up.Test suite parity
pytest -q→ 174 passedpytest -q→ 174 passedIdentical pass count, no new failures. Diff is 9 files deleted, all empty (0 insertions / 0 deletions per file since they had no content).
Scope
No code logic touched — every deleted file was 0 bytes.