fix(color-studio): pin grid height so column overflow can scroll - #31
Merged
Conversation
.sl-cs used min-height: 100vh, which let the middle grid row (1fr) get pushed open by content. Result: left/main/right overflow: auto never triggered -- the list just pushed the whole grid past the viewport. Switch to height: 100dvh with a vh fallback so the middle 1fr row has a defined upper bound and the three column overflow:auto rules engage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.sl-cs used min-height: 100vh, which let the middle grid row (1fr) get pushed open by content. Result: left/main/right overflow: auto never triggered -- the list just pushed the whole grid past the viewport.
Switch to height: 100dvh with a vh fallback so the middle 1fr row has a defined upper bound and the three column overflow:auto rules engage.