Skip to content

feat(api): api update #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stainless-app merged 1 commit into from
Oct 23, 2024
Merged

feat(api): api update #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions onebusaway-sdk-java-core/src/main/kotlin/org/onebusaway/core/http/RetryingHttpClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,12 @@ private constructor(
return executeWithRetries(request, requestOptions)
}

override fun close() {
httpClient.close()
}
override fun close() = httpClient.close()

private fun isRetryable(request: HttpRequest): Boolean {
private fun isRetryable(request: HttpRequest): Boolean =
// Some requests, such as when a request body is being streamed, cannot be retried because
// the body data aren't available on subsequent attempts.
return request.body?.repeatable() ?: true
}
request.body?.repeatable() ?: true

private fun setRetryCountHeader(request: HttpRequest, retries: Int) {
request.headers.removeAll("x-stainless-retry-count")
Expand Down Expand Up @@ -170,12 +167,11 @@ private constructor(
}
}

private fun shouldRetry(throwable: Throwable): Boolean {
private fun shouldRetry(throwable: Throwable): Boolean =
// Only retry IOException and OnebusawaySdkIoException, other exceptions are not intended to
// be
// retried.
return throwable is IOException || throwable is OnebusawaySdkIoException
}
throwable is IOException || throwable is OnebusawaySdkIoException

private fun getRetryBackoffMillis(retries: Int, response: HttpResponse?): Duration {
// About the Retry-After header:
Expand Down