Skip to content

Chore/run server easily#1

Closed
MatiasOS wants to merge 5 commits into
OneCommunityGlobal:Developement_For_Accepting_PRfrom
MatiasOS:chore/run_server_easily
Closed

Chore/run server easily#1
MatiasOS wants to merge 5 commits into
OneCommunityGlobal:Developement_For_Accepting_PRfrom
MatiasOS:chore/run_server_easily

Conversation

@MatiasOS
Copy link
Copy Markdown

I was try to run the server with old URI mongodb://${process.env.user}:${encodeURIComponent(process.env.password)}@${process.env.cluster}/${process.env.dbName}?ssl=true&replicaSet=${process.env.replicaSetName}&authSource=admin
and it is excessive secure and hard to configure.
Dev env must be easy to run and start.
I have replaced with a single env variable uri = mongodb://${process.env.MONGO_URI}.
It allow to run mongoDB local without configurations.
Also, I have added a simple README.md file with the instructions.

@MatiasOS
Copy link
Copy Markdown
Author

I think that is a good idea to have a develop branch to separate the work in progress from work done.

@SowmyaManohar
Copy link
Copy Markdown
Contributor

I highly recommend working in a separate branch, as the code right here is actually not a development version.

@MatiasOS
Copy link
Copy Markdown
Author

MatiasOS commented Jul 31, 2018

@SowmyaManohar What do you mean with a separate branch? My idea is to take a develop branch that belongs to OneCommunityGlobal and then I can create PR to that branch.

@SowmyaManohar
Copy link
Copy Markdown
Contributor

The current Master branch is hosted in Azure. So it's kind of production branch. We can create a new branch if you want to work separately in HGNRest.

@MatiasOS
Copy link
Copy Markdown
Author

@SowmyaManohar That will be cool if you can add a branch to add my reviewed code.

@MatiasOS MatiasOS changed the base branch from master to Developement_For_Accepting_PR August 4, 2018 09:25
@MatiasOS
Copy link
Copy Markdown
Author

MatiasOS commented Sep 8, 2018

I will close this because the lacking of response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants