Skip to content

hot fix auto bluesquares cannot assigned#245

Merged
one-community merged 1 commit into
developmentfrom
Yiyun-hotfix_bluesquares_cannot_auto_assigned
Dec 8, 2022
Merged

hot fix auto bluesquares cannot assigned#245
one-community merged 1 commit into
developmentfrom
Yiyun-hotfix_bluesquares_cannot_auto_assigned

Conversation

@EvianTan
Copy link
Copy Markdown
Contributor

@EvianTan EvianTan commented Dec 8, 2022

This is part of bug fix PR for high priority bug #1 as below image.
image

This PR would only fix "automatically blue squares cannot be assigned" problem, the other one - "blue squares cannot be assigned/deleted/edited" problem will be fixed later.

How did I find the cause:

  1. No infringement or email were triggered this Sunday, which supposed to happen when the user either didn't submit enough time or write weekly summary.
  2. I checked key function assignBlueSquareForTimeNotMet in src\helpers\userHelper.js, which seems to work normally
  3. I checked database some people's lastWeekTangibleHrs are zeros, which should be their the week before last hours, instead of last week hours. Because of the Thanksgivings is on the week before last, many people took off.
  4. From the below image, we know the lastWeekTangibleHrs should be updated once a week. But this function seemed not called this Sunday

image

5. Figured out because of the naming change of this function, but didn't change where used it, so it didn't get called.

image (2)

image (3)

6. Verified the upper related changes got merge into main last week, this Sunday is the only one week couldn't trigger blue square recently.

Note:
After rechecking this PR. I also did some other changes due to naming mismatch.

Copy link
Copy Markdown
Contributor

@KaixiangGU KaixiangGU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! 👍

@one-community one-community merged commit 3da7a6d into development Dec 8, 2022
@EvianTan EvianTan deleted the Yiyun-hotfix_bluesquares_cannot_auto_assigned branch March 23, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants