hot fix auto bluesquares cannot assigned#245
Merged
one-community merged 1 commit intoDec 8, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of bug fix PR for high priority bug #1 as below image.

This PR would only fix "automatically blue squares cannot be assigned" problem, the other one - "blue squares cannot be assigned/deleted/edited" problem will be fixed later.
How did I find the cause:
assignBlueSquareForTimeNotMetinsrc\helpers\userHelper.js, which seems to work normallylastWeekTangibleHrsare zeros, which should be their the week before last hours, instead of last week hours. Because of the Thanksgivings is on the week before last, many people took off.lastWeekTangibleHrsshould be updated once a week. But this function seemed not called this Sunday
5. Figured out because of the naming change of this function, but didn't change where used it, so it didn't get called.
6. Verified the upper related changes got merge into main last week, this Sunday is the only one week couldn't trigger blue square recently.Note:
After rechecking this PR. I also did some other changes due to naming mismatch.