Juhitha took over for Jiayu & Shuhua - All Inventory Types page functionalities by Shuhua-L · Pull Request #765 · OneCommunityGlobal/HGNRest

Shuhua-L · 2024-02-23T05:55:13Z

Description

Implement the functionalities of the All Inventory Types page, which the UI was implemented in this PR

Related PRS (if any):

To test this backend PR you need to checkout the #3833 frontend PR.

Main changes explained:

Added missing PUT routes for updating inventory types (Reusables, Equipments, Consumables, Tools)
Added missing DELETE routes for removing inventory types across all categories
Fixed POST route for Reusables inventory type (was completely missing)
Added missing POST/DELETE routes for inventory units management
Updated bmInventoryTypeRouter.js with comprehensive CRUD operations for all inventory types
Integrated controller methods for updateSingleInvType, deleteSingleInvType, addInvUnit, deleteInvUnit

How to test:

Check into current branch Shuhua-Types_List_Page_Edit_Delete
Do npm install && npm start to run this PR locally on port 4500
Checkout the frontend cleanup branch
Verify all inventory type operations work:

GET: Fetch Materials, Consumables, Tools, Equipment, Reusables
POST: Add new inventory types for all categories
PUT: Update existing inventory types
DELETE: Remove inventory types

…om/OneCommunityGlobal/HGNRest into Shuhua-Types_List_Page_Edit_Delete

skaush21 · 2024-02-24T22:19:00Z

left comment on frontend PR #1984

brandta-1

Review

Refer to front end review.

skaush21

comment on frontend PR 1984

XiaohanMeng

Hi, I left my comment on FE project: OneCommunityGlobal/HighestGoodNetworkApp#1984 (review)

ShengjieMao

Left review in frontend pr

20chen-7

Good job! The add/delete works as described.

But I strongly recommend add back to previous btn here.

Everything is wonderful!

…]()

yvonnep165

Hi @Shuhua-L , I tested this PR with the frontend PR 1984 and everything worked as intended. I left a comment in the frontend PR.

kabraambika

I have provided comment in frontend PR #1984

varunreddy03

I have provided my comments in the related frontend PR #1984.

adityasure9

Hi @Shuhua-L,

I tested the PR according to the instructions, and I encountered the following issues:

After editing and saving changes on the Inventory Types page, the entire page becomes unresponsive and gets stuck. This issue prevents further interaction with the page, making it difficult to proceed with other actions like adding or deleting items.
I noticed similar errors as mentioned by other reviewers, particularly related to the frontend not loading properly due to compile-time errors.
Given these issues, it seems there are some bugs that need to be addressed before this can be merged. Please let me know if you need any further details or testing on my end.

1.mp4

Thanks for your efforts on this!

honglinchen0524 · 2025-01-15T21:55:07Z

Hi! I've added my comment on the frontend PR #1984, great work!

jeyanthi-sm · 2025-01-22T21:14:09Z

I have added my comment to the frontend PR - https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/1984#issuecomment-2608262046

SSP24SCM16G

Please refer to frontend review OneCommunityGlobal/HighestGoodNetworkApp#1984 (review)

rohith1667

Reviewed frontend pr 1984 all the changes are implemented. all the features are working as mentioned.

Screen.Recording.2025-03-01.at.6.06.02.PM.mov

HSP24SCM69K

Reviewed Frontend PR #1984 – All requested changes have been successfully implemented, and all features are functioning as expected.

rishwa344

I reviewed this PR and verified that adding, editing, and deleting inventory types are working as expected. However, after editing an inventory type, the page becomes unresponsive and throws a console error. The issue resolves only after refreshing the page. Other functionalities, including adding and deleting inventory units, are working fine.

sriramsme · 2025-03-12T20:57:53Z

#everyone please re-review this PR. Updates were made on frontend.

humemah · 2025-03-29T02:51:13Z

Followed the steps and verified that the API handles inventory updates, unit management, responses, and error messages correctly.

Anusha-Gali

Hi Juhitha,

I have reviewed your PR locally and have mentioned my comments in the frontend PR: OneCommunityGlobal/HighestGoodNetworkApp#3833 (review)

… and reusable type endpoint - Add /invtypes/:type/:invtypeId route for PUT and DELETE to match frontend URL - Fix Mongoose discriminator issue: resolve correct subtype model (MatType, ConsType, etc.) in updateInventoryType and updateNameAndUnit so fields like unit and fuelType are no longer silently dropped by the base model - Add addReusableType controller and POST /invtypes/reusables route - Add addInventoryUnit and deleteInventoryUnit controller functions and routes Made-with: Cursor

sonarqubecloud · 2026-04-06T00:28:01Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

one-community · 2026-04-06T01:14:47Z

Thank you all, merging!

Shuhua-L added 9 commits January 27, 2024 20:46

added routers, controllers for adding/deleting units

cb44bc7

added routers updating/deleting types

042b1ff

added routers, controllers for adding/deleting units

d4a9c60

added routers updating/deleting types

aebcdf6

added routers, controllers for adding/deleting types

8155760

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

9d27654

Merge branch 'Shuhua-Types_List_Page_Edit_Delete' of https://github.c…

0e7e8e5

…om/OneCommunityGlobal/HGNRest into Shuhua-Types_List_Page_Edit_Delete

fix plural of equipment for consistency

4752afd

change all categories to singular for consistency

d45ef01

Shuhua-L mentioned this pull request Feb 23, 2024

Jiayu --> Shuhua - All Inventory Types page functionalities OneCommunityGlobal/HighestGoodNetworkApp#1984

Closed

brandta-1 suggested changes Feb 25, 2024

View reviewed changes

skaush21 approved these changes Feb 26, 2024

View reviewed changes

XiaohanMeng self-requested a review February 27, 2024 19:39

XiaohanMeng approved these changes Feb 27, 2024

View reviewed changes

ShengjieMao approved these changes Mar 1, 2024

View reviewed changes

20chen-7 reviewed Mar 15, 2024

View reviewed changes

yvonnep165 approved these changes Apr 12, 2024

View reviewed changes

one-community added Do Not Review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. labels May 12, 2024

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

2b22f4b

peter6866 removed Do Not Review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. labels Jun 16, 2024

fixed bug

1a70bf5

one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jul 1, 2024

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

514520b

kabraambika approved these changes Jul 19, 2024

View reviewed changes

varunreddy03 approved these changes Aug 9, 2024

View reviewed changes

adityasure9 suggested changes Aug 11, 2024

View reviewed changes

one-community changed the title ~~Shuhua - All Inventory Types page functionalities~~ Jiayu took over for Shuhua - All Inventory Types page functionalities Aug 11, 2024

SSP24SCM16G reviewed Feb 23, 2025

View reviewed changes

rohith1667 approved these changes Mar 2, 2025

View reviewed changes

HSP24SCM69K approved these changes Mar 8, 2025

View reviewed changes

rishwa344 suggested changes Mar 10, 2025

View reviewed changes

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

dcbe70f

honglinchen0524 removed the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 29, 2025

rahulprasad2823 mentioned this pull request May 17, 2025

Rahul - Cleanup/shuhua inventory types page OneCommunityGlobal/HighestGoodNetworkApp#3540

Merged

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

dec2460

Juhitha-Reddy force-pushed the Shuhua-Types_List_Page_Edit_Delete branch from 04517a6 to dec2460 Compare August 2, 2025 03:53

Juhitha-Reddy added 3 commits August 2, 2025 00:12

Updated Add and Edit Inventory APIs

60c2724

Fixed controller routes

d4b1321

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

7eb62e1

Juhitha-Reddy mentioned this pull request Aug 2, 2025

Juhitha - Cleanup the inventory types page OneCommunityGlobal/HighestGoodNetworkApp#3833

Merged

Juhitha-Reddy self-assigned this Aug 2, 2025

one-community changed the title ~~Jiayu took over for Shuhua - All Inventory Types page functionalities~~ Juhitha took over for Jiayu & Shuhua - All Inventory Types page functionalities Dec 19, 2025

one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 22, 2025

Anusha-Gali approved these changes Dec 25, 2025

View reviewed changes

Juhitha-Reddy added 5 commits January 3, 2026 21:00

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

ef7a7b6

updated the delete api for typelist

13ea5a1

fixed text issue

e5375c6

Merge branch 'development' into Shuhua-Types_List_Page_Edit_Delete

b8f9bc6

one-community merged commit d182cad into development Apr 6, 2026
3 checks passed

one-community mentioned this pull request Apr 8, 2026

Backend Release to Main [2.97] #2157

Merged

Uh oh!

Conversation

Shuhua-L commented Feb 23, 2024 • edited by Juhitha-Reddy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related PRS (if any):

Main changes explained:

How to test:

Uh oh!

skaush21 commented Feb 24, 2024

Uh oh!

brandta-1 left a comment

Choose a reason for hiding this comment

Review

Uh oh!

skaush21 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XiaohanMeng left a comment

Choose a reason for hiding this comment

Uh oh!

ShengjieMao left a comment

Choose a reason for hiding this comment

Uh oh!

20chen-7 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvonnep165 left a comment

Choose a reason for hiding this comment

Uh oh!

kabraambika left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

varunreddy03 left a comment

Choose a reason for hiding this comment

Uh oh!

adityasure9 left a comment

Choose a reason for hiding this comment

Uh oh!

honglinchen0524 commented Jan 15, 2025

Uh oh!

jeyanthi-sm commented Jan 22, 2025

Uh oh!

SSP24SCM16G left a comment

Choose a reason for hiding this comment

Uh oh!

rohith1667 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HSP24SCM69K left a comment

Choose a reason for hiding this comment

Uh oh!

rishwa344 left a comment

Choose a reason for hiding this comment

Uh oh!

sriramsme commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

humemah commented Mar 29, 2025

Uh oh!

Anusha-Gali left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 6, 2026

Quality Gate passed

Uh oh!

one-community commented Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Shuhua-L commented Feb 23, 2024 •

edited by Juhitha-Reddy

Loading

skaush21 left a comment •

edited

Loading

20chen-7 left a comment •

edited

Loading

kabraambika left a comment •

edited

Loading

rohith1667 left a comment •

edited

Loading

sriramsme commented Mar 12, 2025 •

edited

Loading