Juhitha - Cleanup the inventory types page#3833
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Worked on verifying all inventory type operations including viewing different inventory categories (Materials, Tools, Equipment, etc.), adding new inventory types, editing existing ones, and deleting them. While most functionalities worked as expected, it was noted that the dark mode UI and the delete buttons are currently not functioning properly and need further attention. |
Namitha7070
left a comment
Namitha7070
left a comment
There was a problem hiding this comment.
Tested this PR. The add feature for all fields(materials, consumables, equipments, etc) are working fine but the edit and delete features are not getting updated.
Untitled.video.-.Made.with.Clipchamp.2.mp4
shashankm9
left a comment
shashankm9
left a comment
There was a problem hiding this comment.
I have tested this PR. Add feature is working in all the Inventory Types But Edit and delete functions are not works in any of those and dark mode is not working at all. Inventory Types are not legible when curious is hovering on then, change the text color to white maybe.
PR.3833.mp4
Juhitha-Reddy
changed the title
|
@Rishitha1810 , @shashankm9, @Namitha7070 , I verified the PR in my local and the add, edit and delete functionalities are working as expected. Could you please check if you have updated the api endpoint to local while testing and please let me know if the issue still persists. |
one-community
added
the
High Priority - Please Review First
one-community
changed the title
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Juhitha,
I have reviewed your PR locally and all the functionality works as expected but as mentioned by you i do not see dark mode implemented for the page.
3833.mp4
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Juhitha,
Thanks for updating and working on the issue. I have reviewed your PR locally and the dark mode works as per requirement.
- Resolve merge conflicts in 6 frontend files (TypeRow, TypesTable, invUnitsTable, InventoryTypesList, inventoryTypeConstants, TypesList.module.css) keeping inline edit/add approach with relative imports - Add backend route /invtypes/:type/:invtypeId for PUT and DELETE to match frontend URL pattern (fixes "Cannot DELETE/PUT" errors) - Fix Mongoose discriminator issue in updateInventoryType and updateNameAndUnit: resolve correct subtype model before updating so discriminator-specific fields like unit and fuelType are no longer silently dropped - Add requestor.requestorId from Redux auth state in addInvType action to prevent backend destructuring crash on add operations - Add Equipment field mapping (desc for description) in addInvType action - Add addReusableType backend controller and POST /invtypes/reusables route - Add deleteInventoryType export to invTypeActions for DeleteInvTypeModal - Merge dark mode styles from both branches in TypesList.module.css Made-with: Cursor
|
|
Thank you all, merging! |
7 participants
Description
Cleanup and refinement of the All Inventory Types page functionality, building upon the work done in PR #3540. This PR addresses remaining issues and improves the implementation of inventory type management features originally developed by Shuhua and later updated by Rahul.
Fixes critical import path issues, API endpoint configuration, and ensures robust communication with the backend inventory management system.
Related PRS (if any):
This frontend PR is related to the #765 backend PR.
To test this frontend PR you need to checkout the #765 backend PR.
Main changes explained:
How to test:
NOTE: Please make sure you pointing to local api endpoints (http://localhost:4500/api) by updating in the .env file this application.
Screenshots or videos of changes:
Screen.Recording.2025-07-26.at.7.58.15.AM.mov