Skip to content

Ramya Lint fix Add Userprofile - Userprofile subcomponent - #1624

Closed
scoopstroop92 wants to merge 5 commits into
developmentfrom
Ramya-UserProfile-AddNreUserProfile-LintFix
Closed

Ramya Lint fix Add Userprofile - Userprofile subcomponent #1624
scoopstroop92 wants to merge 5 commits into
developmentfrom
Ramya-UserProfile-AddNreUserProfile-LintFix

Conversation

@scoopstroop92

@scoopstroop92 scoopstroop92 commented Dec 2, 2023

Copy link
Copy Markdown

200w

Description

  • Lint fix for the AddUserProfile (sub module) of the UserProfile Component

Main changes explained:

  • Commented out print statements ( Will remove it once the PR is ready to merge )
  • Enforced a function type for function components
  • Fixed variable names to adhere to camel case
  • Removed unused variables and functions
  • Enforced a convention in module import order
  • Reordered the function definitions order
  • Un-nested ternary expressions
  • Require default cases in switch statements

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Verify if the application works as expected with respect to Adding UserProfile
  4. Open the UserProfile Bar component in your editor and report if you see possible error / warnings .

Note:

Thoroughly test the Add User new User functionality and report any error you see so that I can go ahead make similar changes in the other submodules of UserProfile component

@this-journey this-journey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I attempted to create a basic new volunteer user and came across the error "An unknown error occurred while attempting to create this user." I've attached a video for reference. The console shows an error that states:

index.js:1 Warning: Failed prop type: Invalid prop invalid of type string supplied to Input, expected boolean.
in Input (at UserProfileAdd.jsx:716)
in AddUserProfile (created by Connect(AddUserProfile))
in Connect(AddUserProfile) (created by Connect(Connect(AddUserProfile)))
in Connect(Connect(AddUserProfile)) (at NewUserPopup.jsx:54)
in div (created by ModalBody)
in ModalBody (at NewUserPopup.jsx:53)
in div (created by Modal)
in div (created by Modal)
in div (created by Transition)
in Transition (created by Fade)
in Fade (created by Modal)
in div (created by Modal)
in Portal (created by Modal)
in Modal (at NewUserPopup.jsx:39)
in Unknown (created by Connect(Component))
in Connect(Component) (at UserManagement.jsx:134)
in div (created by Container)
in Container (at UserManagement.jsx:70)
in UserManagement (created by Connect(UserManagement))
in Connect(UserManagement) (at ProtectedRoute.jsx:41)
in Route (at ProtectedRoute.jsx:32)
in ProtectedRoute (created by Connect(ProtectedRoute))
in Connect(ProtectedRoute) (at routes.js:129)
in Switch (at routes.js:64)
in Switch (at routes.js:55)
in Router (created by BrowserRouter)
in BrowserRouter (at App.jsx:54)
in PersistGate (at App.jsx:53)
in Provider (at App.jsx:52)
in App (at src/index.js:11)

PR.1624.FE.mov

@scoopstroop92

Copy link
Copy Markdown
Author

@this-journey Thank you for the error logs. That helped. I have fixed the errors. Could you retest and let me know your observations

@EvianTan EvianTan closed this Mar 2, 2025
@sayali-2308 sayali-2308 mentioned this pull request Feb 4, 2026
@EvianTan
EvianTan deleted the Ramya-UserProfile-AddNreUserProfile-LintFix branch July 24, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants