Skip to content

Amalesh-Frontend-Pages-For-New-Google-Form-Equivalent-For-Technical-Support-And-Advisory-Volunteer-Agreement#3356

Merged
one-community merged 5 commits into
developmentfrom
amalesh-tsaform-frontend
Apr 6, 2025
Merged

Amalesh-Frontend-Pages-For-New-Google-Form-Equivalent-For-Technical-Support-And-Advisory-Volunteer-Agreement#3356
one-community merged 5 commits into
developmentfrom
amalesh-tsaform-frontend

Conversation

@Amalesh-A
Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

This is a frontend PR.
To test this frontend PR you need to checkout the development branch of the backend.

Main changes explained:

  • Added a new component TSAForm

How to test:

  1. check into current branch.
  2. do npm install and ... to run this PR locally.
  3. Log in to the app.
  4. Navigate to 'http://localhost:3000/tsaformpage1'.

Screenshots or videos of changes:

TSAFom.mp4

Verify the Following:

  1. Check if the forms are accessible.
  2. Check if you are able to answer the questions.
  3. Check if you are able to navigate to the next page only if you answer the mandatory questions.
  4. Check if you are able to see an error when you try to skip a mandatory question.
  5. Check for UI responsiveness.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 3, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 02cf509
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67f1c43079eca30008680ce3
😎 Deploy Preview https://deploy-preview-3356--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 3, 2025
@manushajyasta30 manushajyasta30 self-requested a review April 3, 2025 23:17
manushajyasta30
manushajyasta30 previously approved these changes Apr 3, 2025
Copy link
Copy Markdown
Contributor

@manushajyasta30 manushajyasta30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloned front end code branch and followed all the steps mentioned in the PR.

  1. able to access the URL
  2. validated the mandatory fields error on clicking next without filling mandatory fields.
  3. Able to successfully submit the form.
image

linh2020
linh2020 previously approved these changes Apr 4, 2025
Copy link
Copy Markdown
Contributor

@linh2020 linh2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Accessed the form at http://localhost:3000/tsaformpage1
  • All 8 pages are accessible.
  • Validation for required questions is working.
  • Users cannot move forward unless required fields are filled.
  • Error messages are shown properly.
  • The UI is responsive and user-friendly.
  • Final form submission works without errors.
  • Everything works as expected.

2025-04-03 23_33_18-HGN APP and 2 more pages - Your Microsoft Edge - Microsoft​ Edge

2025-04-03 23_33_49-Amalesh-Frontend-Pages-For-New-Google-Form-Equivalent-For-Technical-Support-And-

2025-04-03 23_35_17-HGN APP and 2 more pages - Your Microsoft Edge - Microsoft​ Edge

2025-04-03 23_35_41-HGN APP and 2 more pages - Your Microsoft Edge - Microsoft​ Edge

rsripathi2906
rsripathi2906 previously approved these changes Apr 4, 2025
Copy link
Copy Markdown

@rsripathi2906 rsripathi2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch and tested the new TSAForm component.

  1. Forms are accessible.
  2. Able to answer questions without issues.
  3. Mandatory question validation works correctly.
  4. Navigation to the next page is restricted until required fields are filled.
  5. Error messages appear when skipping mandatory questions.
  6. UI responsiveness is working as expected.
Screen.Recording.2025-04-04.132915_1.mp4

myeeli
myeeli previously approved these changes Apr 4, 2025
Copy link
Copy Markdown
Contributor

@myeeli myeeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The form is accessible and i was able to move to next page only if i fill all the mandatory fields and i was able to submit it. The page works perfectly for varying screen sizes.
PR 3356 - 1
PR 3356 - 2

@Dharmik1710
Copy link
Copy Markdown
Contributor

Reviewed the TSA Form pages and verified that the multi-page navigation, field validation, and required input enforcement are all functioning as expected. The form correctly prevents users from skipping required fields and maintains state across pages.

Tested in both light and dark modes and the layout remains responsive on smaller screen sizes. Error handling and transitions are smooth. No issues found with form validation, page navigation, or overall UX.

Everything looks good from the frontend perspective. Great work putting this together!

Screenshot 2025-04-04 at 6 19 29 PM Screenshot 2025-04-04 at 6 19 39 PM Screenshot 2025-04-04 at 6 21 04 PM

Copy link
Copy Markdown
Contributor

@vaibhavkoladiya vaibhavkoladiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works perfectly – the forms are accessible, the validations are in place, errors show up when mandatory questions are skipped, and the UI is responsive. One thing I did notice, though – when I hit the back button, it seems like the user has to re-enter all the answers again. Correct me if I’m wrong, but is there a way we can retain those inputs to avoid re-filling the form?

Screen.Recording.2025-04-04.165646.mp4

Copy link
Copy Markdown
Contributor

@pavanputti pavanputti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TSAForm component works as expected. The form fields are accessible, mandatory questions must be answered before proceeding, and error messages appear when skipped, and error handling prevents submission without required answers. Overall, the component is functioning well.

Screen.Recording.2025-04-04.at.8.59.50.PM.mov

pavanputti
pavanputti previously approved these changes Apr 5, 2025
@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit c1d2d14 into development Apr 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants