Skip to content

Amalesh TSAForm - HotFix#3406

Open
Amalesh-A wants to merge 2 commits into
developmentfrom
amalesh-tsaform-frontend-fix
Open

Amalesh TSAForm - HotFix#3406
Amalesh-A wants to merge 2 commits into
developmentfrom
amalesh-tsaform-frontend-fix

Conversation

@Amalesh-A
Copy link
Copy Markdown
Contributor

Description

429754486-05f499f9-268d-4c69-a518-c58c83228cd7

Related PRS (if any):

This frontend PR is an update of the #3356 frontend PR.
To test this PR you need to checkout the development branch of the backend.

Main changes explained:

  • Before:
  1. URL Pattern: 'tsaformpage1', 'tsaformpage2', etc.
  2. Users can bypass form logic by manually entering URLs to access later pages, even without completing previous pages.
Before.mp4
  • After:
  1. URL Pattern: 'tsaform/page1', 'tsaform/page2', etc.
  2. Page access is now sequentially controlled.
  3. If a user tries to skip ahead by manipulating the URL, they are redirected to the next valid page in their form progress - i.e., the page immediately following the last submitted one.
After.mp4

How to test:

  1. Check into current branch
  2. Do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Log in as an User.
  5. Go to 'http://localhost:3000/tsaform/page1'
  6. Verify if you are able to manipulate the URL to access pages that cannot be accessed without submitting the necessary page.

Note:

  1. Check if the forms are accessible.
  2. Check if you are able to answer the questions.
  3. Check if you are able to navigate to the next page only if you answer the mandatory questions.
  4. Check if you are able to see an error when you try to skip a mandatory question.
  5. Check for UI responsiveness.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 5f55871
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67fc03c52683f60008c9bdb2
😎 Deploy Preview https://deploy-preview-3406--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown

@palankigreeshma1109 palankigreeshma1109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and followed all the steps mentioned in the PR and navigated to http://localhost:3000/tsaform/page1.
verified that everything is working as expected.
Below is the screen recording for your reference.

HGN.APP.-.Personal.-.Microsoft_.Edge.2025-04-12.08-45-51.mp4

@pavanputti pavanputti requested review from palankigreeshma1109 and removed request for palankigreeshma1109 April 12, 2025 14:36
rsripathi2906
rsripathi2906 previously approved these changes Apr 12, 2025
Copy link
Copy Markdown

@rsripathi2906 rsripathi2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested thoroughly. Sequential page access is working as intended. URL manipulation redirects correctly. Form validation and navigation behave as expected.

Screen.Recording.2025-04-12.094943_1.mp4

Copy link
Copy Markdown
Contributor

@vaibhavkoladiya vaibhavkoladiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the current branch, ran npm install and started the app. Cleared site data/cache, logged in as a user, and accessed the TSA form. Verified that restricted pages can't be accessed without completing the required steps. Confirmed that forms are accessible, questions can be answered, navigation to the next page is allowed only after answering mandatory questions, appropriate errors appear when skipping required fields, and the UI is responsive. Approving the PR.

Untitled.video.-.Made.with.Clipchamp.3.mp4

Copy link
Copy Markdown
Contributor

@KH07 KH07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and functioned as intended. I checked out the current branch, ran npm install, and started the app locally. On the TSA Form page, accessing the next page without submitting all required fields will redirect to the current page. Submitting the current page without filling in all required fields will fail. All fields on page 1 through 8 are answerable and accessing page number beyond 8 will redirect to ‘Page Not Found’.

PR.3406.mov

Copy link
Copy Markdown
Contributor

@guthaVamshi guthaVamshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected. Checked out the current branch, ran npm install, and started the app locally. On the TSA Form page, attempting to navigate to the next page without completing all required fields correctly redirects back to the current page. Submitting an incomplete form also fails as intended. All fields from pages 1 to 8 are functional, and accessing any page beyond 8 redirects to the "Page Not Found" screen.

Screen.Recording.2025-04-17.at.11.15.57.AM.mov

Copy link
Copy Markdown
Contributor

@rahulprasad2823 rahulprasad2823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally after checking out the branch and running npm install. The TSA Form behaves as expected
incomplete forms redirect properly, pages 1–8 are functional, and navigating beyond page 8 shows the "Page Not Found" screen.

HGN.APP.-.Personal.-.Microsoft.Edge.2025-04-17.11-48-13.mp4

Copy link
Copy Markdown

@Babu-kota Babu-kota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitled.video.-.Made.with.Clipchamp.mp4

Tested thoroughly. Sequential page access is working as intended. URL manipulation redirects correctly. Form validation and navigation behave as expected.

Copy link
Copy Markdown

@rohithmallipudi rohithmallipudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and followed all the testing steps mentioned. Navigated to http://localhost:3000/tsaform/page1 and verified that URL manipulation no longer allows skipping ahead in the form. The redirection logic works correctly based on form progress, and everything is functioning as expected.
Screenshot 2025-07-12 at 12 11 08 PM
Screenshot 2025-07-12 at 12 14 23 PM
Screenshot 2025-07-12 at 12 12 06 PM
Screenshot 2025-07-12 at 12 10 47 PM

Copy link
Copy Markdown

@gurusaichittoji7 gurusaichittoji7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working as expected, Aprroved.
Screenshot 2025-07-12 235418
Screenshot 2025-07-12 235433
Screenshot 2025-07-13 000558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants