Vamsi krishna impl a permission to view task extension count by vamsikrishna1704 · Pull Request #3402 · OneCommunityGlobal/HighestGoodNetworkApp

vamsikrishna1704 · 2025-04-11T22:36:41Z

Description

Related PRS (if any):

This frontend PR is related to the #1326 backend PR.
To test this frontend PR you need to checkout the #1326 backend PR.
…

Main changes explained:

Added the permission into permissions list.
Displaying the task extension count to users with 'viewTaskExtensionCount' or Owner role.
…

How to test:

check into current branch
do npm install and npm run start:local to run this PR locally
Clear site data/cache
log as admin user
go to Other links-> PermissionManagement->ManageUserPermissions->Select user -> Add permission See # times time added to task.
Able to see the task deadline extension count.
verify this new feature works in dark mode

Screenshots or videos of changes:

FrontendDemo.mp4

…count' of https://github.com/OneCommunityGlobal/HighestGoodNetworkApp into Vamsi_Krishna_Impl_a_permission_to_view_task_extension_count

netlify · 2025-04-11T22:36:58Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`86ef7ff`
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68a68ac076e9bd0007c1bcf3
😎 Deploy Preview	https://deploy-preview-3402--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

palankigreeshma1109

I have reviewed this PR and followed all the steps mentioned in the PR and navigated to Other links-> PermissionManagement->ManageUserPermissions->Select user -> Add permission See # times time added to task.
i icon in owner login page

verified the permission for owner and admin role

Added the permission to volunteer

After login in as volunteer the small i icon is not shown

Please let me know if you need any further reviewing of this PR.

vamsikrishna1704 · 2025-04-12T22:11:19Z

Hi @palankigreeshma1109, this PR is about the task extension count, not about the icon. I can see the task extension count spanning next to time progress in your screenshot as expected. I would request you to go through the PR once again to find any other problems in it. Thank you.

karnati007

Checked out the current branch, ran npm install and npm run start:local, and cleared site data/cache. Logged in as an admin user and navigated to Other Links → Permission Management → Manage User Permissions. Selected a user and added the “See # times time added to task” permission. Verified that the user is now able to see the task deadline extension count. Also confirmed that the feature works correctly in dark mode with no UI issues. Approving this PR. ✅

JuliaHa0902

I have checked out and tested the branch. I logged in as Owner and was able to see the Task Extension count. I am able to give "See Task Extension Count" to other roles and users. Tested in both light and dark mode. I changed the task time and can see that the count is updated. I logged in as a Volunteer with the permission and confirmed that Task Extension Count is visible. I approved the PR.

Requested changes for another feature.

gopikalakshmia

Checkout the branch. In the application, go to Other Links → Permissions Management → Select the Owner/Admin role → Added "see # of times Time Added to Task" for the Volunteer role.

logged in as a Volunteer and verified that the Task Extension count is visible in both Light and Dark themes.

Removed the "See # of Times Time Added to Task"

Task Extension count is not visible

Working as expected ,Approving the PR

AnthonyWeathers

Followed instructions, and added the permission to my admin account and after relogin, was able to see the red circle containing the task deadline extension count for members. Also tested and verified the count is displayed in both light and dark mode.

PR is approved.

mvreddy13

Added the permission to the volunteer user account

The task extension count can be seen after the user got the permission

Deekshith010905 · 2025-07-01T02:57:31Z

When logged in as an admin and navigating to Permission Management, the "See # of Times Time Added to Task" permission is showing as disabled,

nathanah

LGTM

…ew_task_extension_count

karnati007

Hi @vamsikrishna1704, I have tested out the updated code and it is working as intended. Now that you have only allowed users with permission to view task extension deadline, it eliminated unnecessary role based check. Nice work.

…ighestGoodNetworkApp into Vamsi_Krishna_Impl_a_permission_to_view_task_extension_count

karnati007

Hi @vamsikrishna1704, As the changes you have made resolved the merge conflicts with development branch by keeping the functionalities stay unchanged. I am satisfied with the code and approving to be merged into development. Thank you.
Before permission:

After permission:

one-community · 2025-08-22T03:27:20Z

Thank you all, merging!

vamsikrishna1704 added 3 commits April 9, 2025 16:30

Added a permission into permissions list

86d19f6

Merge branch 'Vamsi_Krishna_Impl_a_permission_to_view_task_extension_…

441afad

…count' of https://github.com/OneCommunityGlobal/HighestGoodNetworkApp into Vamsi_Krishna_Impl_a_permission_to_view_task_extension_count

Added comments at the code additions

8fb5ef2

vamsikrishna1704 mentioned this pull request Apr 11, 2025

Vamsi Krishna - Added 'viewTaskExtensionCount' permission to Owner & Admin OneCommunityGlobal/HGNRest#1326

Merged

vamsikrishna1704 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 11, 2025

palankigreeshma1109 previously requested changes Apr 12, 2025

View reviewed changes

vamsikrishna1704 closed this Apr 12, 2025

vamsikrishna1704 reopened this Apr 12, 2025

vamsikrishna1704 requested review from karnati007 and palankigreeshma1109 April 12, 2025 23:53

karnati007 previously approved these changes Apr 16, 2025

View reviewed changes

vamsikrishna1704 added the High Priority label Apr 18, 2025

JuliaHa0902 previously approved these changes Apr 23, 2025

View reviewed changes

gopikalakshmia previously approved these changes Apr 25, 2025

View reviewed changes

AnthonyWeathers previously approved these changes Apr 27, 2025

View reviewed changes

mvreddy13 previously approved these changes May 15, 2025

View reviewed changes

nathanah requested changes May 28, 2025

View reviewed changes

Comment thread src/components/PermissionsManagement/PermissionsConst.js

Comment thread src/components/TeamMemberTasks/TeamMemberTask.jsx Outdated

Fixed the permission logic to view task extension count

9e7cf54

vamsikrishna1704 dismissed stale reviews from mvreddy13, AnthonyWeathers, gopikalakshmia, JuliaHa0902, and karnati007 via 9e7cf54 June 25, 2025 22:20

vamsikrishna1704 requested a review from nathanah June 25, 2025 22:21

vamsikrishna1704 added 2 commits June 25, 2025 18:27

Removed unnecessary "rolesAllowedToSeeTaskExtensionDeadline" constant.

c38003e

removed unnecessary key in PermissionsConst.js

d4bc32f

nathanah previously approved these changes Jul 3, 2025

View reviewed changes

Comment thread src/components/PermissionsManagement/PermissionsConst.js

Merge branch 'development' into Vamsi_Krishna_Impl_a_permission_to_vi…

2efd43c

…ew_task_extension_count

vamsikrishna1704 dismissed nathanah’s stale review via 2efd43c July 4, 2025 21:41

Added description field to edit task section in PermissionsConst.js

2bbc543

vamsikrishna1704 requested review from karnati007 and nathanah and removed request for palankigreeshma1109 July 4, 2025 21:54

karnati007 previously approved these changes Jul 5, 2025

View reviewed changes

Merge branch 'development' of https://github.com/OneCommunityGlobal/H…

86ef7ff

…ighestGoodNetworkApp into Vamsi_Krishna_Impl_a_permission_to_view_task_extension_count

vamsikrishna1704 dismissed karnati007’s stale review via 86ef7ff August 21, 2025 02:55

vamsikrishna1704 requested a review from karnati007 August 21, 2025 03:00

karnati007 approved these changes Aug 21, 2025

View reviewed changes

one-community merged commit f4a04df into development Aug 22, 2025
8 checks passed

one-community mentioned this pull request Aug 25, 2025

Frontend Release to Main [4.40] #3959

Merged

Uh oh!

Uh oh!

Conversation

vamsikrishna1704 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Uh oh!

netlify Bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for highestgoodnetwork-dev ready!

Uh oh!

palankigreeshma1109 left a comment

Choose a reason for hiding this comment

Uh oh!

vamsikrishna1704 commented Apr 12, 2025

Uh oh!

karnati007 left a comment

Choose a reason for hiding this comment

Uh oh!

JuliaHa0902 left a comment

Choose a reason for hiding this comment

Uh oh!

gopikalakshmia left a comment

Choose a reason for hiding this comment

Uh oh!

AnthonyWeathers left a comment

Choose a reason for hiding this comment

Uh oh!

mvreddy13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Deekshith010905 commented Jul 1, 2025

Uh oh!

nathanah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karnati007 left a comment

Choose a reason for hiding this comment

Uh oh!

karnati007 left a comment

Choose a reason for hiding this comment

Uh oh!

one-community commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

vamsikrishna1704 commented Apr 11, 2025 •

edited

Loading

netlify Bot commented Apr 11, 2025 •

edited

Loading