Fix/error connect

[ByteZhang1024]

Summary by CodeRabbit

• New Features

  • Added timeout handling and improved cleanup logic when waiting for pending device operations, enhancing reliability during device interactions.

• Chores

  • Updated version numbers and synchronized dependency versions across multiple packages to 1.0.32 for improved consistency and compatibility.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This update bumps version numbers from 1.0.31 to 1.0.32 across multiple packages and updates internal dependencies to match. In the core logic, it adds a timeout to promise handling, updates function signatures, and improves cleanup for pending device method calls.

Changes

File(s)	Change Summary
.../electron-example/package.json, .../expo-example/package.json, .../shared/package.json	Bumped version from 1.0.31 to 1.0.32. Updated internal dependencies in expo-example.
.../core/package.json, .../hd-ble-sdk/package.json, .../hd-common-connect-sdk/package.json	Bumped version to 1.0.32. Updated internal dependencies to 1.0.32.
.../hd-transport-http/package.json, .../hd-transport-lowlevel/package.json	Bumped version to 1.0.32. Updated internal dependencies to 1.0.32.
.../hd-transport-react-native/package.json, .../hd-transport-webusb/package.json	Bumped version to 1.0.32. Updated internal dependencies to 1.0.32.
.../hd-transport/package.json, .../hd-web-sdk/package.json	Bumped version to 1.0.32. Updated internal dependencies in hd-web-sdk to 1.0.32.
.../core/src/core/index.ts	Added waitWithTimeout helper. Updated waitForPendingPromise to use timeout and cleanup callback.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Core
    participant Device

    Caller->>Core: Call device method
    Core->>Core: Check for prePendingCallPromise
    alt prePendingCallPromise exists
        Core->>Core: waitForPendingPromise(get, remove)
        Core->>Core: waitWithTimeout(promise, 5s)
        alt Promise resolves
            Core->>Core: removePrePendingCallPromise(promise)
        else Timeout
            Core->>Core: removePrePendingCallPromise(promise)
        end
    end
    Core->>Device: Proceed with method call
    Device-->>Core: Return result
    Core-->>Caller: Return result

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1901319 and 62802e1.

📒 Files selected for processing (13)

• packages/connect-examples/electron-example/package.json (1 hunks)
• packages/connect-examples/expo-example/package.json (2 hunks)
• packages/core/package.json (2 hunks)
• packages/core/src/core/index.ts (5 hunks)
• packages/hd-ble-sdk/package.json (2 hunks)
• packages/hd-common-connect-sdk/package.json (2 hunks)
• packages/hd-transport-http/package.json (2 hunks)
• packages/hd-transport-lowlevel/package.json (2 hunks)
• packages/hd-transport-react-native/package.json (2 hunks)
• packages/hd-transport-webusb/package.json (2 hunks)
• packages/hd-transport/package.json (1 hunks)
• packages/hd-web-sdk/package.json (2 hunks)
• packages/shared/package.json (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	has@​1.0.3
	node-releases@​2.0.14
	side-channel@​1.0.4
	@​nicolo-ribaudo/​eslint-scope-5-internals@​5.1.1-v1
	has-proto@​1.0.1
	asynciterator.prototype@​1.0.0
	array-buffer-byte-length@​1.0.0
	typed-array-buffer@​1.0.0
	gopd@​1.0.1
	iterator.prototype@​1.1.2
	globalthis@​1.0.3
	has-property-descriptors@​1.0.0
	has-tostringtag@​1.0.0
	which-collection@​1.0.1
	has-property-descriptors@​1.0.1
	object.groupby@​1.0.1
	is-set@​2.0.3 ⏵ 2.0.2	+1		-2
	is-weakmap@​2.0.2 ⏵ 2.0.1	+1		-1
	safe-regex-test@​1.0.0
	array.prototype.tosorted@​1.1.2
	object.hasown@​1.1.3
	is-map@​2.0.3 ⏵ 2.0.2	+1		-3
See 385 more rows in the dashboard

View full report