Feat/fix init - #508
Conversation
WalkthroughThis update bumps the version numbers for several packages from Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Core
participant Messages
Client->>Core: Send Initialize request
Core->>Messages: Build Initialize message with is_contains_attach (bool)
Messages-->>Core: Return message schema
Core-->>Client: Respond with Initialize message (includes is_contains_attach)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
♻️ Duplicate comments (4)
packages/hd-ble-sdk/package.json (1)
3-3: Same as previous comment – ensure thealpha.3versions are published and the lock-file is in sync.Also applies to: 23-25
packages/hd-web-sdk/package.json (1)
3-3: Same check here: confirm publish + lock-file update.Also applies to: 24-27
packages/hd-transport-react-native/package.json (1)
3-3: Same check here: confirm publish + lock-file update.Also applies to: 22-23
packages/hd-transport-lowlevel/package.json (1)
3-3: Same check here: confirm publish + lock-file update.Also applies to: 22-23
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (15)
packages/connect-examples/electron-example/package.json(1 hunks)packages/connect-examples/expo-example/package.json(1 hunks)packages/connect-examples/expo-playground/package.json(1 hunks)packages/core/package.json(2 hunks)packages/core/src/data/messages/messages.json(1 hunks)packages/hd-ble-sdk/package.json(2 hunks)packages/hd-common-connect-sdk/package.json(2 hunks)packages/hd-transport-emulator/package.json(2 hunks)packages/hd-transport-http/package.json(2 hunks)packages/hd-transport-lowlevel/package.json(2 hunks)packages/hd-transport-react-native/package.json(2 hunks)packages/hd-transport-webusb/package.json(2 hunks)packages/hd-transport/package.json(1 hunks)packages/hd-web-sdk/package.json(2 hunks)packages/shared/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build (20.x)
- GitHub Check: lint (20.x)
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (8)
packages/hd-transport/package.json (1)
3-3: Sync or add a CHANGELOG entryI couldn’t find any changelog file in the repo.
• If you maintain one, add a1.0.39-alpha.3entry and push a matching git tag.
• If not, consider creating a CHANGELOG for future releases.packages/core/src/data/messages/messages.json (1)
6068-6070: Confirmed: Field ID 8001 is unique
No other occurrences of"id": 8001were found in the repo.packages/shared/package.json (1)
3-3: Version bump looks finePackage version now matches repo-wide bump. No other issues spotted.
packages/connect-examples/electron-example/package.json (1)
5-5: Double-check hidden depsOnly app version changed. If this project pulls SDK packages through monorepo workspaces, ensure their versions also bumped; otherwise builds may mix ±2 versions.
packages/core/package.json (1)
3-3: Core package bump consistentVersion and internal deps now point to
1.0.39-alpha.3. Looks clean.Also applies to: 28-30
packages/hd-common-connect-sdk/package.json (1)
3-3: Version bump looks good
No functional impact spotted.packages/hd-transport-http/package.json (1)
3-3: Version updated consistently
Matches the ecosystem bump.packages/hd-transport-emulator/package.json (1)
3-3: Version bump confirmed
Change is simple and safe.
3 participants
Summary by CodeRabbit
New Features
Chores