Skip to content

fix(meta): add guard check for the ClientSettingsPacket - #182

Merged
theEvilReaper merged 3 commits into
mainfrom
fix/settings
Aug 13, 2026
Merged

fix(meta): add guard check for the ClientSettingsPacket#182
theEvilReaper merged 3 commits into
mainfrom
fix/settings

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

The game disguises the Slender player as an Enderman. This causes issues with the ClientSettingsPacket, as an Enderman is not a player entity. To avoid unwanted refreshSettings calls, this pull request adds an additional guard check.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@TheMeinerLP TheMeinerLP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

Test results

228 files  228 suites   1m 54s ⏱️
269 tests 264 ✅  5 💤 0 ❌
810 runs  795 ✅ 15 💤 0 ❌

Results for commit 9ad3d40.

@theEvilReaper
theEvilReaper merged commit 31d05cf into main Aug 13, 2026
7 checks passed
@theEvilReaper
theEvilReaper deleted the fix/settings branch August 13, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants