fix(ci): checkout Android SDK explicitly in bump-kmp reusable workflow#2694
Merged
Conversation
Reusable workflow_call keeps the caller's github.repository, so bare actions/checkout was cloning OneSignal-KMP-SDK and the bump push got a 403 from onesignal-deploy. Pin repository/ref to this repo instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📊 Diff Coverage Report✓ Coverage check passed (no source files changed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The KMP Release →
bump-androidjob failed after tagging v0.1.1:Permission to OneSignal/OneSignal-KMP-SDK.git denied to onesignal-deployRoot cause: in a
workflow_callreusable workflow,actions/checkoutdefaults to the caller repo (OneSignal-KMP-SDK), not the repo that owns the workflow. The bump step then created a self-submodule gitlink in KMP and tried to push there.Fix
Pin
repository: OneSignal/OneSignal-Android-SDKandref: mainin the checkout step.Follow-up
After this lands, re-run the KMP Release bump (or dispatch this workflow with
kmp_version=v0.1.1/kmp_sha=4864ae1…) to open the submodule bump PR. The tag/GitHub Release already succeeded.Test plan
Bump KMP Submodulewithv0.1.1/ SHA from the KMP release, or re-run the failed bump job after a no-op release retry pathOneSignal-Android-SDKand updates theOneSignal-KMP-SDKgitlink onlyMade with Cursor