fix: [SDK-5161] normalize notification payloads across platforms - #1994
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
sherwinski
reviewed
Sep 9, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
sherwinski
approved these changes
Sep 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Align notification payload types with native values and add iOS demo action-button icon resources.
Details
Motivation
Android previously exposed
rawPayloadas a JSON string while iOS exposed an object. This aligns Android with iOS and the public TypeScript API. It also correctslockScreenVisibilityto the numeric value supplied by the Android SDK and adds demo resources for testing notification action-button icons.Scope
rawPayloadJSON into a React Native object.lockScreenVisibilitytype fromstringtonumber.Apps that parse Android
rawPayloadwithJSON.parseshould consume it directly as an object instead.Testing
Unit testing
OSNotificationtests for object payloads and numeric lock-screen visibility.vp testpasses../gradlew :react-native-onesignal:testDebugUnitTestpasses.Manual testing
Not performed. Automated tests cover the payload conversion and TypeScript model changes; the demo README documents manual action-icon verification.
Affected code checklist
Checklist
Overview
Testing
Final pass