Skip to content

fix(responses): repair missing terminal item IDs - #14

Merged
OnlineChef merged 4 commits into
mainfrom
fix/responses-item-id-repair-hardening
Jul 25, 2026
Merged

fix(responses): repair missing terminal item IDs#14
OnlineChef merged 4 commits into
mainfrom
fix/responses-item-id-repair-hardening

Conversation

@OnlineChef

@OnlineChef OnlineChef commented Jul 25, 2026

Copy link
Copy Markdown

Summary

Fixes the responsesItemIdRepair.repairMissingTerminalIds path that previously returned before minting an ID when a message or reasoning output item omitted id.

Changes

  • mint a canonical per-stream ID for missing message and reasoning item IDs when the opt-in is enabled;
  • persist the mapping by item type and output_index;
  • reuse the same ID in later lifecycle events and the final response.output snapshot;
  • preserve disabled-by-default byte-for-byte behavior;
  • add regressions for missing terminal IDs and the disabled path;
  • replace the non-existent workflow-lint action with pinned raven-actions/actionlint;
  • remove the duplicate advanced CodeQL steps from this workflow because repository default setup blocks advanced-setup uploads.

Scope

Three files: the repair implementation, its focused test file, and CI workflow repair. No routing, provider, auth, function-call, package, or release behavior changes. CodeQL remains provided by repository default setup rather than duplicated inside ci.yml.

Validation

GitHub CI runs cross-platform typecheck, tests, privacy scan, GUI lint/build, package-install smoke, npm audit, and workflow lint. React Doctor is green. The new full CI attempt is running on the current head.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@OnlineChef, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ccea0e9b-870c-491f-8e2b-00d524bacd67

📥 Commits

Reviewing files that changed from the base of the PR and between baadc83 and fd6bdb5.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • src/server/responses-item-id-repair.ts
  • tests/responses-item-id-repair.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/responses-item-id-repair-hardening

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

OnlineChef and others added 2 commits July 25, 2026 15:14
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
@OnlineChef
OnlineChef merged commit 056a83c into main Jul 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant