fix: truncate markdown image name context to prevent OS filename limit - #236
Merged
EricNGOntos merged 1 commit intoAug 3, 2026
Merged
Conversation
When last_context (the preceding markdown text) is very long, the generated image filename exceeds the OS 255-byte limit and os.rename fails with OSError ENAMETOOLONG. Truncate to 60 chars after sanitization.
EricNGOntos
approved these changes
Aug 3, 2026
EricNGOntos
left a comment
EricNGOntos
left a comment
Contributor
There was a problem hiding this comment.
LGTM — real filename-too-long fix; context is cosmetic. Follow-up will unify the truncate length with table asset naming (80).
3 tasks
EricNGOntos
added a commit
that referenced
this pull request
Aug 3, 2026
* fix: share one 80-char cap for image and table asset filenames Unify the post-#236 image context truncate with table header naming so cosmetic asset stems use a single MAX_ASSET_FILE_NAME_CHARS constant. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: handle None from path_handle before truncating image titles Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
last_context(the markdown text preceding an image) is very long, the generated image filename exceeds the OS 255-byte limit, causingos.renameto fail withOSError: [Errno 36] File name too long.Error
Fix
Truncate
image_name_contextto 60 characters after sanitization inbuild_markdown_image_name(). The context is cosmetic (used in the filename for debuggability), so truncation has no functional impact.Verification
Tested end-to-end with a 44-page PDF that triggered the original error — parsing succeeds after this fix.