✨ feat: prefer latest tag on current branch when resolving tags#2
Merged
Conversation
Improve tag discovery and commit range computation by introducing a helper that finds the latest tag on the current branch and using it consistently across functions. - Add getLatestTagOnBranch(prefix) to obtain current branch and run git describe --match <pattern> against that branch. This centralizes tag lookup and trims whitespace before returning. - Replace ad-hoc git describe invocations in last-release lookup with getLatestTagOnBranch to avoid incorrect tag resolution and simplify error handling. - Use the canonical string (already trimmed by the helper) when trimming the prefix and when constructing git log ranges. - Handle empty tag results consistently (check for empty string instead of byte-length) and preserve fallbacks to analyzing all commits when no prior tag is found. These changes make tag lookup branch-aware, reduce duplicated git invocation logic, and prevent subtle bugs from trimming or handling raw command output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve tag discovery and commit range computation by introducing a
helper that finds the latest tag on the current branch and using it
consistently across functions.
run git describe --match against that branch. This
centralizes tag lookup and trims whitespace before returning.
with getLatestTagOnBranch to avoid incorrect tag resolution and
simplify error handling.
trimming the prefix and when constructing git log ranges.
instead of byte-length) and preserve fallbacks to analyzing all
commits when no prior tag is found.
These changes make tag lookup branch-aware, reduce duplicated git
invocation logic, and prevent subtle bugs from trimming or handling
raw command output.