Loading saved settings damages options

[Gregorsky]

Describe the bug

Hi, since your last fix related to saving settings to XML, loading the saved XML using the same app version is no longer restoring the settings correctly. It also causes some options to stop working. I don't think this issue existed before.

Area of issue

Start menu

To reproduce

1. Configure the app and save the settings to XML - changing the Menu type makes the issue easier to notice.
2. Start with a fresh installation and load the previously saved XML settings.

Expected behavior

3. Many settings are not restored correctly after loading the XML.
4. Also using 'Reset all settings' changes the configuration to a different state than the default fresh installation.
5. Changing some options afterwards has no effect on the menu.

Open-Shell version

4.4.198

Windows version

W11 64 Pro

Additional context

No response

[ge0rdi]

I have tried it on my Win11 25H2 machine.

Saved settings to XML. Loaded them back (everything looks as before). Saved XML again. Compared with original XML, they were identical.

Reset all settings seems to work just fine. Just note that Start Menu style is not affected by reset (the setting has (always had) FLAG_NORESET flag in code).
Loaded my original XML after reset, everything looks as it should.

Tried also clean install in Windows Sandbox. Again, didn't notice any issue.

Maybe you can try to describe exactly what steps you are doing (eventually provide your XMLs). What settings do you see to be not restored properly. In such state, save new XML and provide that one so we can verify that given setting has really different value than it should have.
Eventually add some screenshots for clarification.

[Gregorsky]

Many thanks for checking this. I will keep an eye on it. As you pointed out, I was not aware of the Start menu style, which was probably the cause.