Skip to content

feat(collector): support collector_author override on registration (#317) - #318

Merged
SamuelHassine merged 2 commits into
mainfrom
feat/collector-author
Jul 24, 2026
Merged

feat(collector): support collector_author override on registration (#317)#318
SamuelHassine merged 2 commits into
mainfrom
feat/collector-author

Conversation

@SamuelHassine

Copy link
Copy Markdown
Member

Proposed changes

  • Declare the optional collector_author attribute on CollectorManager create attrs,
    mirroring the existing injector_author support on InjectorManager.
  • Forward the optional collector_author configuration key in the registration payload
    built by CollectorDaemon._setup(). When the key is not configured it resolves to
    None and the platform keeps its name-based author fallback.
  • Document the new optional key in the CollectorDaemon docstring.

This lets a collector whose display name is not a good author declare a proper author
for its payloads and arsenal contracts, while the default remains the collector name
(never a generic default like "Filigran").

Testing Instructions

  1. Run any collector without collector_author: payloads keep being authored by the
    collector's name (platform-side fallback, unchanged behavior).
  2. Set collector_author in a collector's configuration hints and restart it: newly
    upserted payloads are authored by the declared author organization.

Related issues

Copilot AI review requested due to automatic review settings July 24, 2026 02:01
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for an optional collector_author override during collector registration, aligning collector registration capabilities with the existing injector-side injector_author behavior.

Changes:

  • Document the new optional collector_author configuration key on CollectorDaemon.
  • Include collector_author in the collector registration payload built by CollectorDaemon._setup().
  • Declare collector_author as an optional create attribute on CollectorManager.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyoaev/daemons/collector_daemon.py Documents and forwards the optional collector_author configuration key in the collector registration payload.
pyoaev/apis/collector.py Extends CollectorManager create schema to accept optional collector_author.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SamuelHassine
SamuelHassine merged commit 15b2969 into main Jul 24, 2026
13 checks passed
@SamuelHassine
SamuelHassine deleted the feat/collector-author branch July 24, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(collectors): support collector_author override on collector registration

3 participants