feat(collector): support collector_author override on registration (#317) - #318
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for an optional collector_author override during collector registration, aligning collector registration capabilities with the existing injector-side injector_author behavior.
Changes:
- Document the new optional
collector_authorconfiguration key onCollectorDaemon. - Include
collector_authorin the collector registration payload built byCollectorDaemon._setup(). - Declare
collector_authoras an optional create attribute onCollectorManager.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyoaev/daemons/collector_daemon.py | Documents and forwards the optional collector_author configuration key in the collector registration payload. |
| pyoaev/apis/collector.py | Extends CollectorManager create schema to accept optional collector_author. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
collector_authorattribute onCollectorManagercreate attrs,mirroring the existing
injector_authorsupport onInjectorManager.collector_authorconfiguration key in the registration payloadbuilt by
CollectorDaemon._setup(). When the key is not configured it resolves toNoneand the platform keeps its name-based author fallback.CollectorDaemondocstring.This lets a collector whose display name is not a good author declare a proper author
for its payloads and arsenal contracts, while the default remains the collector name
(never a generic default like "Filigran").
Testing Instructions
collector_author: payloads keep being authored by thecollector's name (platform-side fallback, unchanged behavior).
collector_authorin a collector's configuration hints and restart it: newlyupserted payloads are authored by the declared author organization.
Related issues