chore(pyproject): cleaning unused dependencies (#217) - #321
Merged
Conversation
Dependency was a transitive one + pyproject points out 3.11 as min version
guzmud
force-pushed
the
chore/217-clean-dependencies
branch
from
July 27, 2026 13:57
c8bbb1b to
fd53da9
Compare
There was a problem hiding this comment.
Pull request overview
This PR cleans up pyproject.toml by removing a set of unused runtime dependencies and relocating build tooling (setuptools) into optional dev dependencies, and it simplifies Protocol importing in the backend protocol definitions consistent with the project’s requires-python = ">=3.11".
Changes:
- Remove multiple unused runtime dependencies from
[project].dependencies. - Move
setuptoolsinto[project.optional-dependencies].devand addcoverageto dev extras. - Simplify
Protocolimport inpyoaev/backends/protocol.pyto usetyping.Protocolunconditionally.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Removes unused runtime deps; adjusts dev extras (adds coverage, moves setuptools). |
| pyoaev/backends/protocol.py | Simplifies Protocol import (now always from typing). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kakudou
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
pyoaev\backends\protocol.py:11:5: DEP003 'typing_extensions' imported but it is a transitive dependency➡️ unused dependency, deleting unrequired retro-compatibility with py38 and below and thus the need for this dependency
pyproject.toml: DEP002 'datefinder' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'python-magic' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'python-magic-bin' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'setuptools' defined as a dependency but not used in the codebase➡️ to move to
devdependenciespyproject.toml: DEP002 'cachetools' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'prometheus-client' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'opentelemetry-api' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'opentelemetry-sdk' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
pyproject.toml: DEP002 'dataclasses-json' defined as a dependency but not used in the codebase➡️ not found in the codebase, to be deleted
scripts\release.py:6:1: DEP001 'OAEV_utils' imported but missing from the dependency definitions➡️ unknown
OAEV_utils?Testing Instructions
pytestdependencyRelated issues
Checklist
Further comments