feat(client): add action_output contract output type (#331) - #332
Merged
Conversation
The platform's ContractOutputType enum already has ActionOutput
("action_output"), used to store raw injector output as a finding with
isFindingCompatible=false so it can be used as a chaining/event filter
without appearing in the Findings tab. Expose the same value here so
injectors (e.g. netexec) can declare it.
There was a problem hiding this comment.
Pull request overview
This PR adds support in the Python client’s contract configuration model for the platform’s existing action_output contract output type, enabling injectors to declare raw “action output” streams that are not finding-compatible while keeping the wire label stable.
Changes:
- Add
ActionOutput = "action_output"toContractOutputTypeinpyoaev/contracts/contract_config.py. - Add a stability test asserting the
action_outputwire label matches the expected platform contract.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyoaev/contracts/contract_config.py |
Extends ContractOutputType enum with the action_output wire label to match the platform contract. |
test/contracts/test_contract_output_types.py |
Adds a wire-label stability test for ContractOutputType.ActionOutput. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
savacano28
approved these changes
Aug 3, 2026
guzmud
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionOutput: str = "action_output"toContractOutputTypeinpyoaev/contracts/contract_config.py, matching the platform's existingio.openaev.database.model.ContractOutputType.ActionOutputenum value exactly.ContractOutputElementalready carries a genericisFindingCompatible: boolfield, so no further class changes are needed — injectors can declare anaction_outputoutput withisFindingCompatible=Falseright away.fileone.Motivation
Closes #331. Related to OpenAEV-Platform/injectors#401 (tracking issue for the client-python + netexec migration to action_output). Follow-up from investigating why netexec's contracts (declared
textoutput) never produce findings on the platform:textfindings would show up in the Findings tab, but netexec's raw stdout is only meant to be usable as a chaining/event filter, not a visible finding. The platform already supports this via theaction_outputtype +isFindingCompatible=false(seeActionOutputOutputProcessor); this PR is the client-side prerequisite so netexec (and other injectors) can actually declare it.Test plan
black --check/isort --check-only/flake8on changed filespytest test/contracts— 8 passed, including the newtest_action_output_wire_label