[JAVA] Only add the JsonCreator import when the file contains an enum#13582
Open
FieteO wants to merge 3 commits intoOpenAPITools:masterfrom
Open
[JAVA] Only add the JsonCreator import when the file contains an enum#13582FieteO wants to merge 3 commits intoOpenAPITools:masterfrom
FieteO wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
Author
|
|
aeca09b to
b1deb04
Compare
59295dd to
ff09091
Compare
ff09091 to
5e0498a
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only add the import for the
@JsonCreatorannotation when the model actually contains it.Currently this import is being added to every generated model, even though it is only needed when a model contains an enum.
This is a general annoyance that could be fixed. In my reasonably large backend service there are 7000 problems, with ~ 6500 coming from unused imports in generated code.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)