[BUG][JAVA] Handling default values leads to wrong defaults or not compilable code fixed#15836
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jun 14, 2023
Merged
Conversation
6 tasks
Member
|
tested locally to confirm the fix: @@ -53,19 +53,19 @@ import org.openapitools.client.JSON;
/**
* DefaultValuesType
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2023-06-14T11:15:48.062201+08:00[Asia/Hong_Kong]")
+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2023-06-14T11:16:28.074870+08:00[Asia/Hong_Kong]")
public class DefaultValuesType {
public static final String SERIALIZED_NAME_STRING_DEFAULT = "stringDefault";
@SerializedName(SERIALIZED_NAME_STRING_DEFAULT)
- private List<String> stringDefault = new ArrayList<>();
+ private List<String> stringDefault = new ArrayList<>(Arrays.asList("[]"));
public static final String SERIALIZED_NAME_STRING_DEFAULT2 = "stringDefault2";
@SerializedName(SERIALIZED_NAME_STRING_DEFAULT2)
- private List<String> stringDefault2 = new ArrayList<>(Arrays.asList("Hallo", "Huhu"));
+ private List<String> stringDefault2 = new ArrayList<>(Arrays.asList("[Hallo, Huhu]"));
public static final String SERIALIZED_NAME_OBJECT_DEFAULT = "objectDefault";
@SerializedName(SERIALIZED_NAME_OBJECT_DEFAULT)
- private List<ObjectType> objectDefault = new ArrayList<>();
+ private List<ObjectType> objectDefault = new ArrayList<>(Arrays.asList([]));
public DefaultValuesType() {
}
@@ -78,7 +78,7 @@ public class DefaultValuesType {
public DefaultValuesType addStringDefaultItem(String stringDefaultItem) {
if (this.stringDefault == null) {
- this.stringDefault = new ArrayList<>();
+ this.stringDefault = new ArrayList<>(Arrays.asList("[]"));
}
this.stringDefault.add(stringDefaultItem);
return this;
@@ -107,7 +107,7 @@ public class DefaultValuesType {
public DefaultValuesType addStringDefault2Item(String stringDefault2Item) {
if (this.stringDefault2 == null) {
- this.stringDefault2 = new ArrayList<>(Arrays.asList("Hallo", "Huhu"));
+ this.stringDefault2 = new ArrayList<>(Arrays.asList("[Hallo, Huhu]"));
}
this.stringDefault2.add(stringDefault2Item);
return this;
@@ -136,7 +136,7 @@ public class DefaultValuesType {
public DefaultValuesType addObjectDefaultItem(ObjectType objectDefaultItem) {
if (this.objectDefault == null) {
- this.objectDefault = new ArrayList<>();
+ this.objectDefault = new ArrayList<>(Arrays.asList([]));
}
this.objectDefault.add(objectDefaultItem);
return this;
(changes were using current master) thanks for the PR. |
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
…mpilable code fixed (OpenAPITools#15836) * (fix): default values for array types will be handled a bit more appropriate * (fix): remove commented out block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes Issue #15835
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
"Im Auftrag der DB Systel GmbH"