[Java][Haskell][Python] fix errors with empty strings, missing basePath#15866
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jun 20, 2023
Merged
[Java][Haskell][Python] fix errors with empty strings, missing basePath#15866wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
|
thanks for the fix. cc @OpenAPITools/generator-core-team |
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
…th (OpenAPITools#15866) * various fixes * generate samples & docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this simple OpenApi file as input for all generators. This uncovered problems in several generators. Some threw an Exception while processing the input, while others generated code that doesn't compile. Most generators couldn't handle the empty strings in this input.
I upgraded quarkus because with the old version, compilation failed with
This is because there is no
serverssection in the input file, and thus no base path. The new version doesn't have this problem.In this PR, I fixed all discovered problems.
It might also make sense to add tests based on the mentioned OpenApi input file. But I don't see a good way of using one input file with all generators. And I didn't want to add one new file for each generator to /bin/configs, because that might be too much. If you have an idea how to add tests for all generators, please let me know.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
@spacether (2019/11) ❤️ @krjakbrjak (2023/02)