Skip to content

[Java][Haskell][Python] fix errors with empty strings, missing basePath#15866

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
martin-mfg:fix-empty-input-strings
Jun 20, 2023
Merged

[Java][Haskell][Python] fix errors with empty strings, missing basePath#15866
wing328 merged 2 commits intoOpenAPITools:masterfrom
martin-mfg:fix-empty-input-strings

Conversation

@martin-mfg
Copy link
Copy Markdown
Contributor

I used this simple OpenApi file as input for all generators. This uncovered problems in several generators. Some threw an Exception while processing the input, while others generated code that doesn't compile. Most generators couldn't handle the empty strings in this input.

I upgraded quarkus because with the old version, compilation failed with

[error]: Build step io.quarkus.resteasy.deployment.ResteasyServletProcessor#jaxrsConfig threw an exception: java.lang.IllegalArgumentException: Path must start with /

This is because there is no servers section in the input file, and thus no base path. The new version doesn't have this problem.

In this PR, I fixed all discovered problems.

It might also make sense to add tests based on the mentioned OpenApi input file. But I don't see a good way of using one input file with all generators. And I didn't want to add one new file for each generator to /bin/configs, because that might be too much. If you have an idea how to add tests for all generators, please let me know.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
    @spacether (2019/11) ❤️ @krjakbrjak (2023/02)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 17, 2023

thanks for the fix.

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 7.0.0 milestone Jun 20, 2023
@wing328 wing328 merged commit 396c675 into OpenAPITools:master Jun 20, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants