Skip to content

Update gradle samples to use gradle wrapper 7.6.3#17035

Merged
wing328 merged 2 commits intomasterfrom
gradle-improve
Nov 12, 2023
Merged

Update gradle samples to use gradle wrapper 7.6.3#17035
wing328 merged 2 commits intomasterfrom
gradle-improve

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 11, 2023

Update gradle samples to use gradle wrapper 7.6.3 to fix build failure of samples due to using gradle 6.x

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @OpenAPITools/generator-core-team

@wing328 wing328 changed the title trigger gradle build Update gradle samples to use gradle wrapper 7.6.3 Nov 11, 2023
@wing328 wing328 added this to the 7.1.0 milestone Nov 11, 2023
@wing328 wing328 marked this pull request as ready for review November 12, 2023 14:01
@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Nov 12, 2023

circleci failure not related to this change.

@wing328 wing328 merged commit 40b1d37 into master Nov 12, 2023
@wing328 wing328 deleted the gradle-improve branch November 12, 2023 14:01
@wing328 wing328 requested a review from jimschubert as a code owner November 12, 2023 14:09
jpuerto pushed a commit to movementsciences/openapi-generator that referenced this pull request Nov 14, 2023
* trigger gradle build

* update gradlew to use 7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant