Skip to content

[csharp][generichost] Form models#18264

Merged
wing328 merged 7 commits intoOpenAPITools:masterfrom
devhl-labs:form-models
Apr 1, 2024
Merged

[csharp][generichost] Form models#18264
wing328 merged 7 commits intoOpenAPITools:masterfrom
devhl-labs:form-models

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

@devhl-labs devhl-labs commented Mar 31, 2024

Adds a new PetStore sample with the following appended to the yaml

  skipFormModel: false
inlineSchemaOptions:
  RESOLVE_INLINE_ENUMS: true

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs devhl-labs requested a review from jimschubert as a code owner March 31, 2024 20:37
@devhl-labs devhl-labs changed the title [csharp][generichost]Form models [csharp][generichost] Form models Mar 31, 2024
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 1, 2024

@devhl-labs
Copy link
Copy Markdown
Contributor Author

This has to merged first
#18265

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 1, 2024

just merged that pr

@wing328 wing328 merged commit 858499f into OpenAPITools:master Apr 1, 2024
@wing328 wing328 added this to the 7.5.0 milestone Apr 1, 2024
@devhl-labs devhl-labs deleted the form-models branch April 1, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants