Run unittest tests with unittest#19121
Merged
Merged
Conversation
Contributor
Author
The unit tests in the following directories are written to unittest, not pytest: * `samples/client/echo_api/python/` * `samples/client/echo_api/python-disallowAdditionalPropertiesIfNotPresent/` If pytest is told to execute these tests, it will log warnings about being unable to collect certain tests.
Contributor
|
@Ichimonji10 do you have the list of warnings generated? AFAIK, pytest should be able to execute unittest without any warnings, by default. |
Contributor
Author
|
Here's the warnings emitted when I locally run Even if pytest can run unittest-style tests, I don't see why that would be done, as no pytest features are being used AFAIK. Switching to unittest means fewer warnings and (at least) one less dependency. |
multani
approved these changes
Jul 13, 2024
Contributor
multani
left a comment
There was a problem hiding this comment.
We can merge this change.
Overall, I think unittest usage would be removed in favor of simpler pytest-based tests, but that's a much larger change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests in the following directories are written to unittest, not pytest:
samples/client/echo_api/python/samples/client/echo_api/python-disallowAdditionalPropertiesIfNotPresent/If pytest is told to execute these tests, it will log warnings about being unable to collect certain tests.