[Core] Consolidate Operation ID generation#19339
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Aug 14, 2024
Merged
[Core] Consolidate Operation ID generation#19339wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
|
https://github.com/OpenAPITools/openapi-generator/actions/runs/10350469557/job/28647111728?pr=19339 looks like the refactoring results in some changes in the samples, can you please take a look when you've time? |
Member
|
cc @OpenAPITools/generator-core-team |
Member
|
the refactoring looks good. thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor core code refactor spotted while doing other development.
Currently we split Operation ID generation across two functions:
getOrGenerateOperationIdandfromOperationThis refactor moves all of the code into
getOrGenerateOperationIdThis has a knock-on effect, which means that callback operation IDs now get correctly created with a camel case name - I think this is an improvement.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Core Team for review: @wing328 , @jimschubert , @cbornet , @jmini , @etherealjoy