Skip to content

[JavaJaxRS] [CXF] Add Support for Jackson3 #23767

Merged
wing328 merged 8 commits into
masterfrom
fwermelskirchen-master
May 13, 2026
Merged

[JavaJaxRS] [CXF] Add Support for Jackson3 #23767
wing328 merged 8 commits into
masterfrom
fwermelskirchen-master

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 12, 2026

to fix #23616

based on #23719

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add Jackson 3 support to the JAX-RS CXF client generator via the new useJackson3 option. When enabled, clients use tools.jackson, CXF 4.2.0, updated provider imports, and require Java 11+; Jackson 2 remains the default.

  • New Features

    • Added useJackson3 to JavaCXFClientCodegen and exposed it as a CLI option.
    • Introduced jacksonPackage to switch between tools.jackson (Jackson 3) and com.fasterxml.jackson (Jackson 2).
    • Updated pom.mustache to use the correct Jackson group/provider, set CXF 4.2.0 and Jackson JAX-RS 3.1.2 for Jackson 3, skip jackson-datatype-jsr310, and remove explicit <java.version> properties.
    • Updated api_test.mustache to import the JSON provider from the selected package and Jakarta variant.
    • Documented useJackson3 and updated the Petstore jaxrs-cxf-client-jackson sample to use useJackson3 and useJakartaEe; removed explicit Java version properties in related samples.
  • Migration

    • Only if you enable useJackson3:
      • Requires Java 11+ and CXF 4.2.0.
      • Uses tools.jackson coordinates and the Jakarta RS JSON provider.
      • Do not include jackson-datatype-jsr310.
      • With useJakartaEe, generated sources use jakarta.ws.rs imports.

Written for commit 9a3f10b. Summary will update on new commits.

@wing328 wing328 changed the title Fwermelskirchen master [JavaJaxRS] [CXF] Add Support for Jackson3 May 12, 2026
@wing328 wing328 marked this pull request as ready for review May 12, 2026 11:18
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 14 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml">

<violation number="1" location="samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml:189">
P1: CXF 4.2.0 requires JDK 17+, but this sample pins `java.version` to 11, which can break compilation/runtime compatibility.</violation>
</file>

<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache:250">
P1: `useJackson3` sets `java.version` to 11, but this branch also upgrades to CXF 4.2.0, which requires a newer JDK baseline. This can generate projects that do not build with the emitted Java version.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml Outdated
Comment thread modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache Outdated
@wing328 wing328 merged commit 5327138 into master May 13, 2026
134 checks passed
@wing328 wing328 deleted the fwermelskirchen-master branch May 13, 2026 08:01
@wing328
Copy link
Copy Markdown
Member Author

wing328 commented May 13, 2026

fyi @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [JavaJaxRS] [CXF] Add Support for Jackson3

2 participants