[JavaJaxRS] [CXF] Add Support for Jackson3 #23767
Merged
Merged
Conversation
…enerator into fwermelskirchen-master
6 tasks
Contributor
There was a problem hiding this comment.
2 issues found across 14 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml">
<violation number="1" location="samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml:189">
P1: CXF 4.2.0 requires JDK 17+, but this sample pins `java.version` to 11, which can break compilation/runtime compatibility.</violation>
</file>
<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache:250">
P1: `useJackson3` sets `java.version` to 11, but this branch also upgrades to CXF 4.2.0, which requires a newer JDK baseline. This can generate projects that do not build with the emitted Java version.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Member
Author
|
fyi @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix #23616
based on #23719
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Add Jackson 3 support to the JAX-RS CXF client generator via the new
useJackson3option. When enabled, clients usetools.jackson, CXF 4.2.0, updated provider imports, and require Java 11+; Jackson 2 remains the default.New Features
useJackson3toJavaCXFClientCodegenand exposed it as a CLI option.jacksonPackageto switch betweentools.jackson(Jackson 3) andcom.fasterxml.jackson(Jackson 2).pom.mustacheto use the correct Jackson group/provider, set CXF 4.2.0 and Jackson JAX-RS 3.1.2 for Jackson 3, skipjackson-datatype-jsr310, and remove explicit<java.version>properties.api_test.mustacheto import the JSON provider from the selected package and Jakarta variant.useJackson3and updated the Petstorejaxrs-cxf-client-jacksonsample to useuseJackson3anduseJakartaEe; removed explicit Java version properties in related samples.Migration
useJackson3:tools.jacksoncoordinates and the Jakarta RS JSON provider.jackson-datatype-jsr310.useJakartaEe, generated sources usejakarta.ws.rsimports.Written for commit 9a3f10b. Summary will update on new commits.