[Java] [vertx] Allow PoolOptions configuration when vertx 5#23829
Open
RickyRister wants to merge 1 commit into
Open
[Java] [vertx] Allow PoolOptions configuration when vertx 5#23829RickyRister wants to merge 1 commit into
RickyRister wants to merge 1 commit into
Conversation
Contributor
Author
|
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/java/vertx5-supportVertxFuture/src/main/java/org/openapitools/client/ApiClient.java">
<violation number="1" location="samples/client/petstore/java/vertx5-supportVertxFuture/src/main/java/org/openapitools/client/ApiClient.java:661">
P2: Changing the protected `buildWebClient` hook from 2 args to 3 args breaks downstream overrides and can silently drop custom WebClient configuration.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| * @return WebClient | ||
| */ | ||
| protected WebClient buildWebClient(Vertx vertx, JsonObject config) { | ||
| protected WebClient buildWebClient(Vertx vertx, JsonObject config, JsonObject poolConfig) { |
Contributor
There was a problem hiding this comment.
P2: Changing the protected buildWebClient hook from 2 args to 3 args breaks downstream overrides and can silently drop custom WebClient configuration.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/java/vertx5-supportVertxFuture/src/main/java/org/openapitools/client/ApiClient.java, line 661:
<comment>Changing the protected `buildWebClient` hook from 2 args to 3 args breaks downstream overrides and can silently drop custom WebClient configuration.</comment>
<file context>
@@ -650,13 +658,13 @@ protected <T> Handler<AsyncResult<HttpResponse<Buffer>>> buildResponseHandler(Ty
* @return WebClient
*/
- protected WebClient buildWebClient(Vertx vertx, JsonObject config) {
+ protected WebClient buildWebClient(Vertx vertx, JsonObject config, JsonObject poolConfig) {
if (!config.containsKey("userAgent")) {
</file context>
Member
|
thanks for the PR cc @sjw2547 who added vertx 5 support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23828
When
useVertx5is enabled, theApiClientwill have an additionalpoolConfigfield. That field is for storing the json that will eventually be mapped to thePoolOptionsthat is passed into theWebClientfactory method alongside theWebClientOptions.We still generate a
ApiClientconstructor with two params (which will just forward to the main constructor, passing an empty json for thepoolConfig) to maintain backwards compatibility.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds configurable connection pool support for Vert.x 5 by introducing a
poolConfigJSON inApiClientand passing it toWebClient.createasPoolOptions. Closes #23828.useVertx5is enabled,ApiClientincludes apoolConfigfield used to buildPoolOptions.ApiClient(Vertx, JsonObject, JsonObject); the existing 2-arg constructor forwards with an empty JSON to keep compatibility.WebClientis now created with bothWebClientOptionsandPoolOptionsderived frompoolConfig.Written for commit bc890da. Summary will update on new commits. Review in cubic