Conversation
wing328
marked this pull request as ready for review
July 26, 2026 07:32
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/samples-java-sbt.yaml">
<violation number="1" location=".github/workflows/samples-java-sbt.yaml:25">
P1: This CI workflow sets Java 17, but the sbt sample it builds (`samples/client/petstore/java/okhttp-gson`) configures `scalaVersion := "2.11.12"` in its `build.sbt`. Scala 2.11.12 does **not** support JDK 17 — the minimum Scala versions for JDK 17 are 2.12.15 and 2.13.6, per the official [Scala JDK Compatibility documentation](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html). The sbt build will likely fail at compile time when the Scala compiler bridge initializes under JDK 17. Update the `scalaVersion` in `samples/client/petstore/java/okhttp-gson/build.sbt` to at least `2.12.15` (or `2.13.6`) alongside this JDK upgrade.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| with: | ||
| distribution: 'temurin' | ||
| java-version: 11 | ||
| java-version: 17 |
Contributor
There was a problem hiding this comment.
P1: This CI workflow sets Java 17, but the sbt sample it builds (samples/client/petstore/java/okhttp-gson) configures scalaVersion := "2.11.12" in its build.sbt. Scala 2.11.12 does not support JDK 17 — the minimum Scala versions for JDK 17 are 2.12.15 and 2.13.6, per the official Scala JDK Compatibility documentation. The sbt build will likely fail at compile time when the Scala compiler bridge initializes under JDK 17. Update the scalaVersion in samples/client/petstore/java/okhttp-gson/build.sbt to at least 2.12.15 (or 2.13.6) alongside this JDK upgrade.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/samples-java-sbt.yaml, line 25:
<comment>This CI workflow sets Java 17, but the sbt sample it builds (`samples/client/petstore/java/okhttp-gson`) configures `scalaVersion := "2.11.12"` in its `build.sbt`. Scala 2.11.12 does **not** support JDK 17 — the minimum Scala versions for JDK 17 are 2.12.15 and 2.13.6, per the official [Scala JDK Compatibility documentation](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html). The sbt build will likely fail at compile time when the Scala compiler bridge initializes under JDK 17. Update the `scalaVersion` in `samples/client/petstore/java/okhttp-gson/build.sbt` to at least `2.12.15` (or `2.13.6`) alongside this JDK upgrade.</comment>
<file context>
@@ -22,7 +22,7 @@ jobs:
with:
distribution: 'temurin'
- java-version: 11
+ java-version: 17
- name: Setup sbt launcher
uses: sbt/setup-sbt@v1
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Update the sbt Java samples CI to run on JDK 17. Also bump Scala to 2.13.6 for
okhttp-gsontemplate and all related samples, and normalize the.openapi-generator-ignoreinsamples/client/petstore/java/okhttp-gson.Written for commit 44b90d1. Summary will update on new commits.