[JAVA] fix jspecify in java builders and toIndentedString - #24601
Closed
jpfinne wants to merge 33 commits into
Closed
[JAVA] fix jspecify in java builders and toIndentedString#24601jpfinne wants to merge 33 commits into
jpfinne wants to merge 33 commits into
Conversation
merge master
Fix for: The following artifacts could not be resolved: org.apache.maven.plugins:maven-enforcer-plugin:pom:3.4.0 (absent): Could not transfer artifact org.apache.maven.plugins:maven-enforcer-plugin:pom:3.4.0 from/to central (https://repo.maven.apache.org/maven2): status code: 429, reason phrase: Too Many Requests (429)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some missing
@Nullableannotations for java clients:toIndentedString()Add a sample for openapiNullable
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes JSpecify nullability in generated Java and Spring Boot 4 code so builder chain setters and all‑args constructors accept @nullable where expected, including for fully qualified types and generics. Adds new
openApiNullable/useOptionalsample configs, updates workflows/tests/samples, and cleans up generated FILES lists.New Features
@Nullablein builder setters via newnullableArgument_builderfor Java and Spring (respectsuseOptionalandoptionalAcceptNullablein Spring).@Nullableto Spring all‑args constructors whenuseJspecifyis enabled.toIndentedString(Object o)as@Nullableacross Java templates and all library variants.spring-boot-4-jspecify-openapiNullable,spring-boot-4-jspecify-useOptional, andjava-restclient-springBoot4-jackson3-jspecify-openapiNullable; CI workflows include them.Bug Fixes
nullableDatatypeWithEnuminnullableArgumentWithEnum.mustache.getLastIndexinAbstractJavaCodegen.nullable_var_annotationsand SpringnullableAnnotationlogic to honoruseJspecify,openApiNullable, anduseOptional(split into default and JSpecify variants)..openapi-generator/FILESto reduce noise in CI.Written for commit c7cbd25. Summary will update on new commits.