Skip to content

Minor improvements to Spring codegen - #24662

Merged
wing328 merged 1 commit into
masterfrom
java-spring-update
Aug 10, 2026
Merged

Minor improvements to Spring codegen#24662
wing328 merged 1 commit into
masterfrom
java-spring-update

Conversation

@wing328

@wing328 wing328 commented Aug 10, 2026

Copy link
Copy Markdown
Member

FYI @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) @KannaKim (2026/07)

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Polished org.openapitools.codegen.languages.SpringCodegen with small cleanups and a logging fix. Improves readability and correctness without changing generated code behavior.

  • Bug Fixes

    • Fixed trace log format string in provide-args processing (removed extra placeholder).
  • Refactors

    • Made RequestMappingMode.description final.
    • Simplified tag handling (isEmpty(), Collections.singletonList); removed an unused variable.
    • Streamlined container return-type parsing and minor checks (size() vs keySet().size(), direct boolean fields).

Written for commit f3f5d0e. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@wing328 wing328 added this to the 7.25.0 milestone Aug 10, 2026
@wing328 wing328 changed the title minor improvements to spring codegen Minor improvements to Spring codegen Aug 10, 2026
@wing328
wing328 merged commit 49418a5 into master Aug 10, 2026
15 checks passed
@wing328
wing328 deleted the java-spring-update branch August 10, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant