[java] use [javaparser] library to detect syntax errors#3715
Merged
jmini merged 1 commit intoOpenAPITools:masterfrom Aug 22, 2019
sullis:use-javaparser-library
Merged
[java] use [javaparser] library to detect syntax errors#3715jmini merged 1 commit intoOpenAPITools:masterfrom sullis:use-javaparser-library
jmini merged 1 commit intoOpenAPITools:masterfrom
sullis:use-javaparser-library
Conversation
Member
|
The Travis CI failure is not related to this change. |
Member
|
+1 This is an interesting change, allowing checking the validity of the code that would have been generated without having to generate it and to run maven/gradle on it. It will not catch all cases as the compiler would to it with the compile dependencies on the classpath, but because this is earlier in the process (unit-test). What version of Java syntax is checked? |
jmini
reviewed
Aug 21, 2019
Contributor
Author
|
@jmini ready for review |
Member
|
Thank you for the this contribution! |
4 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)