Skip to content

Conversation

@Zomzog
Copy link
Contributor

@Zomzog Zomzog commented Oct 25, 2020

Based on this I have replaced RequstPart with RequestParam when the part is not a file.

Ping technical committee:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @lwlee2608 (2019/10) @bkabrda (2020/01)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Zomzog Zomzog force-pushed the 7794_RequestParam branch 2 times, most recently from 1e18c26 to 521cdb7 Compare October 30, 2020 23:43
@Zomzog
Copy link
Contributor Author

Zomzog commented Oct 31, 2020

The last commit has been amened to restart CI jobs, it looks ok now.

@Zomzog Zomzog force-pushed the 7794_RequestParam branch from 521cdb7 to 70bcd29 Compare January 26, 2021 17:35
@Zomzog
Copy link
Contributor Author

Zomzog commented Jan 26, 2021

Rebase done, must fix #7794

Copy link
Contributor

@Dretch Dretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there are lots of files with their mode changed from 100755 → 100644. Is this intentional?

@osimosu
Copy link

osimosu commented Aug 22, 2021

is this going out anytime soon ?

@d35h
Copy link

d35h commented Oct 9, 2021

Hello everyone,

any ETA for this to be shipped?

Thanks,
Dan

@simon-exp
Copy link

Hello.

While waiting for the fix on future versions, is there a workaround to be able to make the spring generation work correctly?
I am in 5.1.1 of the openapi-generator-maven-plugin plugin.

thanks in advance

@DaSilva2010
Copy link

@Zomzog @Dretch Can I help somehow to get this fix merged?

@madanepuri
Copy link

Any ETA on this?

Thanks
Madan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants