http.nonProxyHosts does not work without http.proxyUser, with quotes …

[markieww]

…and more related issues #415

[uhurusurfa]

In principal this looks like a good solution.

The one catch in it is that the proxy configuration can be done either asa system property or as an AS2 property in the properties section of the config.xml or as a properties file provided to AS2 at startup.

So to use this solution you will need to push the proxy properties into the System properties if they are sourced from the Properties object.

I suggest that at the entry to the method, make the first check to the System property with fallback to the Properties and if found in Properties object then search for all possible proxy properties in Properties object and set them into the System property.

[markieww]

In principal this looks like a good solution.

Thanks for having a first look. I hope that I can provide an updated PR next week - it is right busy now.

[markieww]

@uhurusurfa Here is the updated PR with the following changes

• respect proxy configuration from properties
  Note the behaviour-change of using the user/password!
  BEFORE: Use http.proxyUser/http.proxyPassword for https.proxyHost (<-- I guess that was an issue and not intentional)
  NOW: Use https.proxyUser/https.proxyPassword for https.proxyHost
• introduce http.nonProxyHosts for configuration via properties
• Cleanup - Remove unused methods in HTTPUtil

Please review.

[uhurusurfa]

Looks great - thanks for the contribution. 🚀

[markieww]

@uhurusurfa Thank you.

I guess you should close the corresponding issue #415 with a target version too