feat: stop record when --until-cmd exits 0 - #467
Merged
Conversation
The postcondition is not a second terminal. Record polls the check. Exit 0 stops. Ctrl-C remains the fallback. Probe failures keep recording. Opened by an agent session, not the founder.
Need openadapt-capture>=1.2.2 for --macos-app. Say so and stop. Opened by an agent session, not the founder.
Default record output was Capture INFO plus a performance plot. Operator record should stay quiet. Ctrl-C and --until-cmd are unchanged. Opened by an agent session, not the founder.
abrichr
force-pushed
the
feat/record-until-cmd
branch
from
September 4, 2026 02:34
a3ee93d to
de65ed3
Compare
Member
Author
|
Merged by an agent session, not the founder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record already had an internal
stop/stop_whenhook (MockMed tutorial uses it). The CLI did not. Operators had to run the PDI awake oracle in a second terminal so the check was not captured as clicks.--until-cmd CMDpolls CMD while recording. Exit 0 stops. Other exits and probe errors keep recording. Ctrl-C still stops.The command is not part of the demonstration.
Opened by an agent session, not the founder.