fix(ollama): verify model after pull#146
Merged
Merged
Conversation
Confirm a pulled model appears in Ollama before reporting success. Retry the listing once to cover the post-pull visibility race and return a failed result if it remains absent. Add deterministic tests for delayed visibility and permanent absence.
|
🎉 Congratulations @Sanjays2402! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ 🌟 This is your first merged contribution to this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ollama pulls now report success only after the model appears in the installed-model list. The adapter retries the visibility check once after a short backoff and returns a failed
PullResultif the model remains absent.Closes #15
Changes
Testing
pytest -q -m 'not integration'(91 passed)Checklist
feature/,fix/,docs/,refactor/,test/,chore/)mainAGENT.mdcoding standards (type hints, Pydantic v2, no genericException, no business logic in CLI)domain/andports/stay pure (no I/O, no framework imports)ruff,mypy --strict,bandit,pytestpyproject.tomlandsrc/modeldock/__init__.pyversions match (not release-related)