fix: progress bar resets to 1/total_items on completion (#38)#201
Merged
Conversation
Remove redundant completed/total updates that caused the progress bar to briefly show 1/total_items during the loading-to-evaluation transition. - Line 124: Remove completed=1,total=1 (keep task indeterminate during load) - Line 126: Add completed=0 when setting total (clean determinate start) - Line 146: Remove redundant completed=total_items (already set at line 128) Fixes #38
|
🎉 Congratulations @himanshu231204! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The progress bar briefly resets to
1/total_itemsduring the loading-to-evaluation transition inoaeval run.Root cause: At line 124,
completed=1, total=1marks the task "done". At line 126,totalchanges tototal_itemsbutcompletedstays at1, causing Rich to render1/total_items.Fix
3-line change in
openagent_eval/cli/commands/run.py:completed=1, total=1total=total_itemstotal=total_items, completed=0(clean start)completed=total_itemsVerification
ruff check- All checks passedpytest tests/integration/test_cli_integration/test_run.py- 4/4 passed (includingtest_run_shows_progress)Fixes #38